[Kde-pim] Review Request: Reuse QString instances in parseAddrList

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106836/
-----------------------------------------------------------

(Updated Oct. 15, 2012, 12:17 p.m.)


Review request for KDEPIM and KDEPIM-Libraries.


Changes
-------

added memory profiles before/after patch


Description
-------

Leverage QString implicit sharing to reduce memory consumption. In my tests, the memory decreases roughly by ~20MB from a total of 300 down to about 280MB.

My question is rather, whether this really needs to be thread safe or not. Maybe also some performance testing is required?


Diffs
-----

  plugins/akonadi_serializer_mail.h cf43949 
  plugins/akonadi_serializer_mail.cpp 096073a 

Diff: http://git.reviewboard.kde.org/r/106836/diff/


Testing
-------

Ran KMail, not noticeably slower but uses less ram. Nothing else seems to have changed.


Screenshots (updated)
-----------

memory consumption before patch
  http://git.reviewboard.kde.org/r/106836/s/776/
memory consumption after patch
  http://git.reviewboard.kde.org/r/106836/s/777/


Thanks,

Milian Wolff

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/