[Kde-pim] Review Request: Merge akonadi-facebook into kdepim-runtime

Wed Oct 24 15:57:53 BST 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107021/#review20791
-----------------------------------------------------------


resources/facebook/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107021/#comment16390>

    You can most likely strip CMakeLists.txt down considerably, i.e. a lot of that stuff is already declared/defined in kdepim-runtime/CMakeLists.txt


resources/facebook/config.h.cmake
<http://git.reviewboard.kde.org/r/107021/#comment16391>

    this file might not be needed either


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16396>

    not needed


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16397>

    I don't think this is needed, it will be shipped with 4.10


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16399>

    position of &


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16400>

    spaces in ()


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16401>

    spaces in ()


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16402>

    same here


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16403>

    I think QLatin1String( friendsRID )
    

resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16404>

    spaces in setLowerLimit()


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16405>

    better use KABC::Addressee::mimeType()
    same might apply to others
    and spaced in the ()


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16407>

    maybe provide a bit more context, e.g.
    i18nc( "@title: addressbook name", "Friends" )
    see: http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16409>

    spaces in ()


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16410>

    space before )


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16411>

    spaces in ()


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16412>

    space before )


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16413>

    spaces


resources/facebook/facebookresource.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16414>

    spaces


resources/facebook/facebookresource.h
<http://git.reviewboard.kde.org/r/107021/#comment16392>

    explicit FacebookResource


resources/facebook/facebookresource.h
<http://git.reviewboard.kde.org/r/107021/#comment16393>

    since you are not prefixing overrride elsewhere, I'd say remove the virtual here as well


resources/facebook/facebookresource.h
<http://git.reviewboard.kde.org/r/107021/#comment16394>

    and here


resources/facebook/facebookresource.h
<http://git.reviewboard.kde.org/r/107021/#comment16398>

    const QString &errorMessage
    (position of &)


resources/facebook/facebookresource.h
<http://git.reviewboard.kde.org/r/107021/#comment16395>

    spaces in ()


resources/facebook/facebookresource_events.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16415>

    KJob *job


resources/facebook/facebookresource_events.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16416>

    spaces


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16417>

    not needed


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16418>

    Akonadi/ChangeRecorder?


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16419>

    KJob *job


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16420>

    spaces


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16421>

    KJob *job


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16422>

    spaces


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16423>

    spaces


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16424>

    spaces


resources/facebook/facebookresource_friends.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16425>

    spaces in outer ()


resources/facebook/facebookresource_posts.cpp
<http://git.reviewboard.kde.org/r/107021/#comment16426>

    why not just in the if block in line 135?


- Kevin Krammer


On Oct. 24, 2012, 11:39 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107021/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 11:39 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patches adds akonadi-facebook resource into kdepim-runtime. It depends on LibKFacebook, which is currently at [1] and a sysadmin request has been filed to move it to playground.
> 
> [1] - kde:scratch/mklapetek/libkfacebook - http://quickgit.kde.org/index.php?p=scratch%2Fmklapetek%2Flibkfacebook.git&a=summary
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 64a6c1a 
>   resources/CMakeLists.txt c094b57 
>   resources/facebook/CMakeLists.txt PRE-CREATION 
>   resources/facebook/Info.plist.template PRE-CREATION 
>   resources/facebook/Messages.sh PRE-CREATION 
>   resources/facebook/config.h.cmake PRE-CREATION 
>   resources/facebook/facebookresource.cpp PRE-CREATION 
>   resources/facebook/facebookresource.desktop PRE-CREATION 
>   resources/facebook/facebookresource.h PRE-CREATION 
>   resources/facebook/facebookresource_events.cpp PRE-CREATION 
>   resources/facebook/facebookresource_friends.cpp PRE-CREATION 
>   resources/facebook/facebookresource_notes.cpp PRE-CREATION 
>   resources/facebook/facebookresource_notifications.cpp PRE-CREATION 
>   resources/facebook/facebookresource_posts.cpp PRE-CREATION 
>   resources/facebook/icons/CMakeLists.txt PRE-CREATION 
>   resources/facebook/icons/hi16-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi22-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi32-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi48-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hisc-apps-facebookresource.sgvz PRE-CREATION 
>   resources/facebook/settings.h PRE-CREATION 
>   resources/facebook/settings.cpp PRE-CREATION 
>   resources/facebook/settingsbase.kcfg PRE-CREATION 
>   resources/facebook/settingsbase.kcfgc PRE-CREATION 
>   resources/facebook/settingsdialog.h PRE-CREATION 
>   resources/facebook/settingsdialog.cpp PRE-CREATION 
>   resources/facebook/settingsdialog.ui PRE-CREATION 
>   resources/facebook/timestampattribute.h PRE-CREATION 
>   resources/facebook/timestampattribute.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107021/diff/
> 
> 
> Testing
> -------
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/