[Kde-pim] Review Request: Fix bugs in kmail messagelist theme editor.

[Michael Kerrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106875/
-----------------------------------------------------------

(Updated Oct. 15, 2012, 2:02 p.m.)


Review request for KDEPIM.


Description
-------

* Initialize the mTheme private variable to null so that the conditional test that the ThemePreviewWidget is setup correctly in applyThemeColumnWidget works. If we don't initialize this variable and the ThemePreviewWidget isn't setup right then kmail might crash when you try and use the widget. 

* Fix the theme configure dialog window so that the current theme is selected for editing when we open the dialog initially (i.e. setup the ThemePreviewWidget correctly)

* When a new theme is created in the configure dialog window we select that theme for editing straight away.


Note I don't have commit access to repositories


Diffs
-----

  messagelist/utils/configurethemesdialog.cpp 20ce061 
  messagelist/utils/themeeditor.cpp 67206fd 

Diff: http://git.reviewboard.kde.org/r/106875/diff/


Testing
-------

Works on master branch


Thanks,

Michael Kerrin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/