[Kde-pim] Review Request: Put new items from resource sync into proper childEntities collection when using InvisibleCollectionFetch
Martin Klapetek
martin.klapetek at gmail.com
Fri Nov 2 09:17:35 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107153/#review21339
-----------------------------------------------------------
Ping, can anyone review this please?
- Martin Klapetek
On Oct. 31, 2012, 2:59 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107153/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2012, 2:59 p.m.)
>
>
> Review request for KDEPIM-Libraries and Stephen Kelly.
>
>
> Description
> -------
>
> When using ETM with InvisibleCollectionFetch collection fetch strategy, new added items from resource syncing ends up in wrong collection and just empty data are displayed in the view. Debugging this I discovered that the newly created items must be stored with "m_rootCollection.id()" as key instead of "collection.id()" (m_childEntities[collection.id()] is actually empty/non-existant even though the model has valid items from this collection) as the model is actually just a flat list.
>
>
> Diffs
> -----
>
> akonadi/entitytreemodel_p.cpp b1c8378
>
> Diff: http://git.reviewboard.kde.org/r/107153/diff/
>
>
> Testing
> -------
>
> Tested my SocialFeed model, which uses InvisibleCollectionFetch, this fixes showing new items in the plasmoid.
>
>
> Thanks,
>
> Martin Klapetek
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list