[Kde-pim] Review Request: Removed knotes window resizing for RichText toolbar

Allen Winter winter at kde.org
Sun Nov 4 14:08:01 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106882/#review21412
-----------------------------------------------------------

Ship it!


seems fine.  please commit this into the KDE/4.9 branch

- Allen Winter


On Oct. 15, 2012, 4:14 p.m., Slavek Banko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106882/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 4:14 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> In some situations, there are caused multiple change KNote window height due to show / hide the toolbar. KNote Window may consequently inadvertently increase or decrease its height - in multiples of height the toolbar. Observed  particularly with the mode focus follow mouse.
> 
> When I tried to find the cause, I came to the conclusion that changes in height of the window due to the toolbar is impractical in relation to location of other windows. As a handier solution seems to me not to change the height of the window, but to reduce the height of the contents of the note while preserving the overall height of the window.
> 
> 
> Diffs
> -----
> 
>   knotes/knote.cpp 337bd98 
> 
> Diff: http://git.reviewboard.kde.org/r/106882/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Slavek Banko
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list