[Kde-pim] Review Request: Added shortcuts to focus first/last message in messagelist.

[Stefan Fuchs]

> On Nov. 26, 2012, 6:53 a.m., Laurent Montel wrote:
> > messagelist/core/view.cpp, line 1607
> > <http://git.reviewboard.kde.org/r/107437/diff/2/?file=96003#file96003line1607>
> >
> >     why setFocus?

To focus the message-list view widget. Is this focus not required?

Honestly, I had a look at the implementation of focusPreviousMessageItem()/focusNextMessageItem() and implemented the method accordingly.


> On Nov. 26, 2012, 6:53 a.m., Laurent Montel wrote:
> > messagelist/core/view.cpp, line 1628
> > <http://git.reviewboard.kde.org/r/107437/diff/2/?file=96003#file96003line1628>
> >
> >     why setfocus?

Same as above.


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107437/#review22538
-----------------------------------------------------------


On Nov. 23, 2012, 2:57 p.m., Stefan Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107437/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 2:57 p.m.)
> 
> 
> Review request for KDEPIM, David Faure and Laurent Montel.
> 
> 
> Description
> -------
> 
> Adds the following shortcuts to the messagelist:
>   * alt + home: focus first message
>   * alt + end: focus last message
> 
> Please push for me if the patch is accepted.
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.h 6e17981 
>   kmail/kmmainwidget.cpp 483c40f 
>   messagelist/core/view.h f142e25 
>   messagelist/core/view.cpp 9b61acd 
>   messagelist/pane.h 04dbe64 
>   messagelist/pane.cpp 56ab576 
>   messagelist/widget.h 5c76763 
>   messagelist/widget.cpp 7dced54 
> 
> Diff: http://git.reviewboard.kde.org/r/107437/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested shotcuts on local machine with different aggregations.
> 
> 
> Thanks,
> 
> Stefan Fuchs
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/