[Kde-pim] Review Request: ktimetracker tray icon doesn't connect to right signals

Chuso Perez kde at chuso.net
Mon Nov 26 21:01:22 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107482/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

MainWindow tries to connect TrayIcon slots to some signals sent by TimetrackerWidget. But these signals are not being emitted by TimetrackerWidget, they are being emitted by TaskView.
This code patches TimetrackerWidget to receive those TaskView signals and propagate them so MainWindow can receive them to connect them to TrayIcon.


This addresses bug 289009.
    http://bugs.kde.org/show_bug.cgi?id=289009


Diffs
-----

  ktimetracker/timetrackerwidget.cpp f2d1d7a 

Diff: http://git.reviewboard.kde.org/r/107482/diff/


Testing
-------

Those methods from TrayIcon that are expected to be run when the signal is sent (change tray icon and update tool tip) are finally run (they are not being run until now, see bug).


Thanks,

Chuso Perez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list