[Kde-pim] Review Request: Add option for Kolab Format version to accountwizard
Christian Mollekopf
chrigi_1 at fastmail.fm
Mon Nov 5 17:16:05 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107223/
-----------------------------------------------------------
Review request for KDEPIM and Volker Krause.
Description
-------
This patch adds a combobox to the accountwizard allowing to select between format v2 and v3, which will be necessary with the soon to be release Kolab Groupware Server 3.0.
Since autodetection would be errorprone, I opted rather for explicit configuration of the version, so it's a required step during the setup process (otherwise it would later on have to be changed in the kolab resource configuration).
I had to extend the accountwizard configfile class a bit, as I need to do some kind of post-setup, because I need the id of the created imap-resource available. It's a bit of a hack, so I'm open for suggestions, but I couldn't find any easy and clean way to configure the kolab resource, after the imap resource has already been created and I can access it's identifier.
Diffs
-----
accountwizard/configfile.h 179420208da547d4a2505e94925a54bdf06fbdbe
accountwizard/configfile.cpp 5aeef249b91d8ab3da9e0da7454fd91ae4168d86
accountwizard/resource.h de4c4dec60524638adeda14db20106f24be91f89
accountwizard/resource.cpp 20778c1bf40c840c91ab692cb2feb52bfea57228
resources/kolabproxy/wizard/kolabwizard.es 978b8b2dbc8117465528813dcdbc921e6ff8063b
resources/kolabproxy/wizard/kolabwizard.ui b8f396af7c80e03d6e9aa2f524d87879fa619f81
Diff: http://git.reviewboard.kde.org/r/107223/diff/
Testing
-------
Tried it, works for me.
Thanks,
Christian Mollekopf
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list