[Kde-pim] Review Request: Merge "Mailing List Management" into "Folder Properties"

[Anne Wilson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 16/11/2012 20:08, Jonathan Marten wrote:
> 
> ----------------------------------------------------------- This
> is an automatically generated e-mail. To reply, visit: 
> http://git.reviewboard.kde.org/r/107341/ 
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2012, 8:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Changes -------
> 
> Updated in accordance with review comments.
> 
> 
> Description -------
> 
> This change merges the separate "Mailing List Management" dialogue 
> into a tab of "Folder Properties", and also corrects its layout.
> 
> In order to maintain the same user experience, the actions and
> menu structure remain unchanged.  The "Mailing List Management"
> option in the "Folder" menu opens the "Folder Properties" dialogue
> at the appropriate tab (this requires the change to kdepimlibs
> submitted at https://git.reviewboard.kde.org/r/106623/).
> 
> The file that managed the dialogue (now the tab) is mostly
> unchanged, just renamed and with the corresponding class name
> changed. Reviewboard doesn't detect that, hence the big diff.
> 
> In kmmainwidget, the signature of an existing function is changed. 
> This is not BC, but I'm assuming that this is not a problem in 
> application code.  There is a BC-compatible way (but not SC) that 
> this could be done if necessary.
> 
> 
> This addresses bug 115611. 
> http://bugs.kde.org/show_bug.cgi?id=115611
> 
> 
> Diffs (updated) -----
> 
> kmail/CMakeLists.txt 588d63a kmail/collectionmailinglistpage.h 
> PRE-CREATION kmail/collectionmailinglistpage.cpp PRE-CREATION 
> kmail/kmmainwidget.h 390d232 kmail/kmmainwidget.cpp a3668d5 
> kmail/mailinglistpropertiesdialog.h 949566d 
> kmail/mailinglistpropertiesdialog.cpp b5b2998
> 
> Diff: http://git.reviewboard.kde.org/r/107341/diff/
> 
> 
> Testing -------
> 
> Built kdepim with this change, checked operation of dialogue and 
> mailing list functions.
> 
Time after time, users have pointed out that the Mailing List
Management dialog affects only the active folder, so it would make
sense for it to be in Folder Properties.  It really would make a great
difference to user experience.

Anne

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlCnZtwACgkQj93fyh4cnBdzbACfRd85i06WdSHDRyV2iQHly1H0
LxsAn0xRNkkJiXUPkQSQJMbEYs23T+Kf
=dSmA
-----END PGP SIGNATURE-----
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/