[Kde-pim] Review Request: Fix ignoring "warn before sending unsigned / unencrypted messages"

[Laurent Montel]

> On Nov. 7, 2012, 3:59 p.m., Kevin Krammer wrote:
> > kmail/kmcomposewin.cpp, line 2657
> > <http://git.reviewboard.kde.org/r/107240/diff/1/?file=94008#file94008line2657>
> >
> >     Laurent has already committed that if I read the mail to the list correcty, but I wonder if it would make sense to change this to KStandardGuiItem::cancel()
> >

I didn't apply this patch. I ported kmail1 for this feature. so we can close this review.
Regards.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107240/#review21561
-----------------------------------------------------------


On Nov. 7, 2012, 12:21 p.m., Christof Arnosti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107240/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 12:21 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> At the moment, the mail composer just continues to send unencrypted and unsigned emails without any regards of the settings in the kmail security section. I added checks in the doSend-Method and shows a KMessageBox as warning if appropriate.
> 
> 
> This addresses bug https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/1075130.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/1075130
> 
> 
> Diffs
> -----
> 
>   kmail/kmcomposewin.cpp 23287094d1c637f747084a839e026db6ff75c027 
> 
> Diff: http://git.reviewboard.kde.org/r/107240/diff/
> 
> 
> Testing
> -------
> 
> Sent tons of signed and unsigned emails to trigger different warnings.
> 
> 
> Thanks,
> 
> Christof Arnosti
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/