[Kde-pim] Review Request: Akregator: hide the tray icon when there are no unread articles.

[Maarten De Meyer]

> On Nov. 18, 2012, 10:07 a.m., Laurent Montel wrote:
> > akregator/src/trayicon.cpp, line 85
> > <http://git.reviewboard.kde.org/r/107359/diff/2/?file=95111#file95111line85>
> >
> >     better:
> >     if(Setting::enable....() ) {
> >       int oldWidth....
> >       pp.end();
> >       
> >     }
> >     setIconByPixmap(....)
> >     setStatus(KStatusNo...);
> >

Yes, thank you.
We need to have the setIcon calls seperate for performance reasons.


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107359/#review22151
-----------------------------------------------------------


On Nov. 21, 2012, 9:26 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107359/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 9:26 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Using KStatusNotifierItem you can hide applications in the system tray when they have nothing to show to the user. In this case no unread articles.
> It is still possible to make it always visible if you wish.
> 
> 
> This addresses bugs 99653, 231358 and 299770.
>     http://bugs.kde.org/show_bug.cgi?id=99653
>     http://bugs.kde.org/show_bug.cgi?id=231358
>     http://bugs.kde.org/show_bug.cgi?id=299770
> 
> 
> Diffs
> -----
> 
>   akregator/src/trayicon.cpp f0f7dd2 
> 
> Diff: http://git.reviewboard.kde.org/r/107359/diff/
> 
> 
> Testing
> -------
> 
> Tested with unread item count enabled and disabled, tray icon shown and hidden.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/