[Kde-pim] Review Request: Merge "Mailing List Management" into "Folder Properties"

[Jonathan Marten]

> On Nov. 16, 2012, 9:08 p.m., Kevin Krammer wrote:
> > kmail/kmmainwidget.cpp, line 1641
> > <http://git.reviewboard.kde.org/r/107341/diff/2/?file=95011#file95011line1641>
> >
> >     The string should probably be enclosed in QLatin1String()

Will fix.


> On Nov. 16, 2012, 9:08 p.m., Kevin Krammer wrote:
> > kmail/kmmainwidget.cpp, line 4681
> > <http://git.reviewboard.kde.org/r/107341/diff/2/?file=95011#file95011line4681>
> >
> >     I must say I am puzzled that this does not crash.
> >     By default all jobs are autoDelete, creating a job on the stack should therefore result in a double deletion
> 
> Jonathan Marten wrote:
>     Sheer luck?  The job getting compiler-deleted before the next entry to the event loop where its own deleteLater() would take effect.  I'll bet that if the properties dialogue were executed synchronously (dlg->exec()), there would be a crash.
>

Shall I fix this (in a separate commit)?


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107341/#review22094
-----------------------------------------------------------


On Nov. 16, 2012, 8:08 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107341/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2012, 8:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This change merges the separate "Mailing List Management" dialogue into a tab of "Folder Properties", and also corrects its layout.
> 
> In order to maintain the same user experience, the actions and menu structure remain unchanged.  The "Mailing List Management" option in the "Folder" menu opens the "Folder Properties" dialogue at the appropriate tab (this requires the change to kdepimlibs submitted at https://git.reviewboard.kde.org/r/106623/).
> 
> The file that managed the dialogue (now the tab) is mostly unchanged, just renamed and with the corresponding class name changed.  Reviewboard doesn't detect that, hence the big diff.
> 
> In kmmainwidget, the signature of an existing function is changed.  This is not BC, but I'm assuming that this is not a problem in application code.  There is a BC-compatible way (but not SC) that this could be done if necessary.
> 
> 
> This addresses bug 115611.
>     http://bugs.kde.org/show_bug.cgi?id=115611
> 
> 
> Diffs
> -----
> 
>   kmail/CMakeLists.txt 588d63a 
>   kmail/collectionmailinglistpage.h PRE-CREATION 
>   kmail/collectionmailinglistpage.cpp PRE-CREATION 
>   kmail/kmmainwidget.h 390d232 
>   kmail/kmmainwidget.cpp a3668d5 
>   kmail/mailinglistpropertiesdialog.h 949566d 
>   kmail/mailinglistpropertiesdialog.cpp b5b2998 
> 
> Diff: http://git.reviewboard.kde.org/r/107341/diff/
> 
> 
> Testing
> -------
> 
> Built kdepim with this change, checked operation of dialogue and mailing list functions.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/