[Kde-pim] Review Request: DAV resource: reload config when ResourceBase::reloadConfiguration is emitted

Volker Krause vkrause at kde.org
Sat May 26 17:09:46 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105026/#review14186
-----------------------------------------------------------


I can't comment on DAV resource internals, but the general approach looks good to me.

- Volker Krause


On May 24, 2012, 1:48 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105026/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 1:48 p.m.)
> 
> 
> Review request for KDEPIM and Grégory Oestreicher.
> 
> 
> Description
> -------
> 
> Reload the webdav configuration resource when ResourceBase emits reloadConfiguration.
> 
> This is needed to ensure that the resource is configurable by external applications.
> 
> 
> Diffs
> -----
> 
>   resources/dav/resource/davgroupwareresource.h 2a71b26 
>   resources/dav/resource/davgroupwareresource.cpp b66ac83 
>   resources/dav/resource/settings.h fd36cf9 
>   resources/dav/resource/settings.cpp 2cca59b 
> 
> Diff: http://git.reviewboard.kde.org/r/105026/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list