[Kde-pim] Review Request: Cleanup coding style other the directory kdepim-runtime/agents/

Kevin Krammer krammer at kde.org
Mon May 7 12:49:07 BST 2012 


> On May 5, 2012, 3:52 p.m., Kevin Krammer wrote:
> > agents/maildispatcher/sendjob.cpp, line 312
> > <http://git.reviewboard.kde.org/r/104859/diff/1/?file=62627#file62627line312>
> >
> >     space between ( and int
> 
> Guy Maurel wrote:
>     this is also, I think, something we should discuss about.
>     The question:
>     Is it better to change *also* the function-definition-code to include some more "space(s)"?
>     I don't made any change in this (and other) review. 
>     I am ready to make them overall if wished.
>     
>     The next question:
>     what about the use of macros, such as:
>     QCOMPARE(...)                   // without space
>     or
>     QCOMPARE( ... )                 // with some spaces

Right, we can probably update function argument lists in a separate change.


> On May 5, 2012, 3:52 p.m., Kevin Krammer wrote:
> > agents/nepomukfeeder/dms-copy/createresourcejob.cpp, line 50
> > <http://git.reviewboard.kde.org/r/104859/diff/1/?file=62633#file62633line50>
> >
> >     d( new Private )
> 
> Guy Maurel wrote:
>     look at my question about the signature of a function.
>     If that, why not change also KJob(0) to KJob( 0 ) such as proposed at the next comment?
>     If wished, I I ready to make the changes overall.

yeah, ignore those for now. we don't need to have a perfect overall change, incremental immprovements are totally fine
oh, an in this case it is in one of the subdirectories we ignore anyway (dms-copy)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104859/#review13472
-----------------------------------------------------------


On May 4, 2012, 5:39 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104859/
> -----------------------------------------------------------
> 
> (Updated May 4, 2012, 5:39 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Cleanup coding style other the directory kdepim-runtime/agents/
> Note: NO signature where changed
> 
> Changing all the occurences of,
> from                 to
> ! expression         !expression
> ))                   ) )
> ){                   ) {
> if(                  if (
> foreach(             foreach (
> do{                  do {
> }while               } while
> ("string")           ( "string" ) 
> (expression)         ( expression ) 
> space at the end of a line
> 
> 
> Diffs
> -----
> 
>   agents/invitations/incidenceattribute.h 3c5b6df 
>   agents/invitations/incidenceattribute.cpp ab4887d 
>   agents/invitations/invitationsagent.cpp 339a6ee 
>   agents/maildispatcher/maildispatcheragent.cpp 1be32e9 
>   agents/maildispatcher/outboxqueue.cpp 8cef358 
>   agents/maildispatcher/sendjob.cpp 7d57135 
>   agents/maildispatcher/storeresultjob.cpp 032aa14 
>   agents/maildispatcher/tests/aborttest.cpp c35be48 
>   agents/maildispatcher/tests/dupetest.cpp d76451e 
>   agents/nepomukfeeder/dms-copy/abstracttimeoutdbusinterface.cpp cc060d3 
>   agents/nepomukfeeder/dms-copy/createresourcejob.h ed5a2c7 
>   agents/nepomukfeeder/dms-copy/createresourcejob.cpp d2195fb 
>   agents/nepomukfeeder/dms-copy/datamanagement.cpp aedf54f 
>   agents/nepomukfeeder/dms-copy/datamanagementinterface.h 6157770 
>   agents/nepomukfeeder/dms-copy/dbustypes.cpp 09e5dde 
>   agents/nepomukfeeder/dms-copy/describeresourcesjob.cpp 5fd4165 
>   agents/nepomukfeeder/dms-copy/genericdatamanagementjob.cpp a5d38f4 
>   agents/nepomukfeeder/dms-copy/interfaces/resourcewatcherconnectioninterface.h afe91f9 
>   agents/nepomukfeeder/dms-copy/kdbusconnectionpool.cpp 43e1f5f 
>   agents/nepomukfeeder/dms-copy/resourcewatcher.cpp f6fc93c 
>   agents/nepomukfeeder/dms-copy/simpleresource.cpp 5293961 
>   agents/nepomukfeeder/dms-copy/simpleresourcegraph.cpp 41c4ee5 
>   agents/nepomukfeeder/dms-copy/storeresourcesjob.cpp 592f280 
>   agents/nepomukfeeder/feederqueue.h 9c55fc1 
>   agents/nepomukfeeder/feederqueue.cpp fc7d399 
>   agents/nepomukfeeder/nepomukfeederagent.h e1390fc 
>   agents/nepomukfeeder/nepomukfeederagent.cpp c407b76 
>   agents/nepomukfeeder/nepomukhelpers.h 7aea22b 
>   agents/nepomukfeeder/nepomukhelpers.cpp 5c99d04 
>   agents/nepomukfeeder/plugin/nepomukfeederutils.cpp 6875230 
>   agents/nepomukfeeder/pluginloader.cpp b3b79b0 
>   agents/nepomukfeeder/plugins/nepomukcalendarfeeder.cpp dfca991 
>   agents/nepomukfeeder/plugins/nepomukcontactfeeder.cpp 241792d 
>   agents/nepomukfeeder/plugins/nepomukmailfeeder.cpp 0a6980b 
>   agents/nepomukfeeder/plugins/nepomuknotefeeder.cpp 04f0af6 
>   agents/nepomukfeeder/test/akonadinepomukfeeder_indexer.cpp a66000c 
>   agents/newmailnotifier/newmailnotifieragent.cpp dbae8c7 
>   agents/ontologies/nao/agent.h ce08924 
>   agents/ontologies/nao/freedesktopicon.h ab9cd03 
>   agents/ontologies/nao/party.h cd9240a 
>   agents/ontologies/nao/symbol.h a0ffcc7 
>   agents/ontologies/nao/tag.h 1be7b21 
>   agents/ontologies/ncal/accessclassification.h 15e1f1c 
>   agents/ontologies/ncal/alarm.h c7a88da 
>   agents/ontologies/ncal/alarmaction.h ea7a468 
>   agents/ontologies/ncal/attachment.h 1639195 
>   agents/ontologies/ncal/attachmentencoding.h a7be056 
>   agents/ontologies/ncal/attendee.h 11a9972 
>   agents/ontologies/ncal/attendeeororganizer.h 10738bf 
>   agents/ontologies/ncal/attendeerole.h 7c1276d 
>   agents/ontologies/ncal/bydayrulepart.h a60e708 
>   agents/ontologies/ncal/calendar.h 4a5fa74 
>   agents/ontologies/ncal/calendardataobject.h a009936 
>   agents/ontologies/ncal/calendarscale.h 67d0a87 
>   agents/ontologies/ncal/calendarusertype.h b575c0e 
>   agents/ontologies/ncal/event.h 2c0c8e6 
>   agents/ontologies/ncal/eventstatus.h 6a7891e 
>   agents/ontologies/ncal/freebusy.h 1d8d3c3 
>   agents/ontologies/ncal/freebusyperiod.h 36eff2a 
>   agents/ontologies/ncal/freebusytype.h 0cd2884 
>   agents/ontologies/ncal/journal.h b1fca07 
>   agents/ontologies/ncal/journalstatus.h c5569c4 
>   agents/ontologies/ncal/ncaldatetime.h 28c7d78 
>   agents/ontologies/ncal/ncalperiod.h 2715c26 
>   agents/ontologies/ncal/ncaltimeentity.h 6efbe4d 
>   agents/ontologies/ncal/organizer.h 39c7f30 
>   agents/ontologies/ncal/participationstatus.h 7fd3c07 
>   agents/ontologies/ncal/recurrencefrequency.h d95fd6d 
>   agents/ontologies/ncal/recurrenceidentifier.h a1ca6b9 
>   agents/ontologies/ncal/recurrenceidentifierrange.h 72e3412 
>   agents/ontologies/ncal/recurrencerule.h d54d627 
>   agents/ontologies/ncal/requeststatus.h 478da68 
>   agents/ontologies/ncal/timetransparency.h c67e9f2 
>   agents/ontologies/ncal/timezone.h 3e0b407 
>   agents/ontologies/ncal/timezoneobservance.h 2dafb79 
>   agents/ontologies/ncal/todo.h b4ca361 
>   agents/ontologies/ncal/todostatus.h d069018 
>   agents/ontologies/ncal/trigger.h 80fbd11 
>   agents/ontologies/ncal/triggerrelation.h 36f1c8b 
>   agents/ontologies/ncal/unionofalarmeventfreebusyjournaltodo.h 12af36b 
>   agents/ontologies/ncal/unionofalarmeventfreebusytodo.h 791cc4d 
>   agents/ontologies/ncal/unionofalarmeventjournaltodo.h 4b15ce9 
>   agents/ontologies/ncal/unionofalarmeventtodo.h 5e25611 
>   agents/ontologies/ncal/unionofeventfreebusy.h 68a8f67 
>   agents/ontologies/ncal/unionofeventfreebusyjournaltodo.h 144e63c 
>   agents/ontologies/ncal/unionofeventjournaltimezonetodo.h adf099a 
>   agents/ontologies/ncal/unionofeventjournaltodo.h b2b0e60 
>   agents/ontologies/ncal/unionofeventtodo.h c25c484 
>   agents/ontologies/ncal/unionoftimezoneobservanceeventfreebusyjournaltimezonetodo.h 3935412 
>   agents/ontologies/ncal/unionoftimezoneobservanceeventfreebusytimezonetodo.h ef7b920 
>   agents/ontologies/ncal/unionoftimezoneobservanceeventjournaltimezonetodo.h 71c55e3 
>   agents/ontologies/ncal/unionparentclass.h 550d403 
>   agents/ontologies/ncal/weekday.h fa66197 
>   agents/ontologies/nco/affiliation.h 10d35f8 
>   agents/ontologies/nco/audioimaccount.h 400737b 
>   agents/ontologies/nco/bbsnumber.h d50dad2 
>   agents/ontologies/nco/carphonenumber.h 63a3b94 
>   agents/ontologies/nco/cellphonenumber.h 0f4c604 
>   agents/ontologies/nco/contact.h 842904a 
>   agents/ontologies/nco/contactgroup.h 9e5f2a3 
>   agents/ontologies/nco/contactlist.h 280b192 
>   agents/ontologies/nco/contactlistdataobject.h 54ef872 
>   agents/ontologies/nco/contactmedium.h 4eaabc5 
>   agents/ontologies/nco/domesticdeliveryaddress.h 1dfd9ad 
>   agents/ontologies/nco/emailaddress.h b50706b 
>   agents/ontologies/nco/faxnumber.h 6092cdd 
>   agents/ontologies/nco/gender.h 3f84560 
>   agents/ontologies/nco/imaccount.h ca6eea7 
>   agents/ontologies/nco/imcapability.h d04cf12 
>   agents/ontologies/nco/internationaldeliveryaddress.h b59550f 
>   agents/ontologies/nco/isdnnumber.h 13af5e5 
>   agents/ontologies/nco/messagingnumber.h a2d5fa5 
>   agents/ontologies/nco/modemnumber.h 0b18b74 
>   agents/ontologies/nco/organizationcontact.h 97d14f9 
>   agents/ontologies/nco/pagernumber.h d8923bd 
>   agents/ontologies/nco/parceldeliveryaddress.h 50d846a 
>   agents/ontologies/nco/pcsnumber.h 2b608be 
>   agents/ontologies/nco/personcontact.h b8aee20 
>   agents/ontologies/nco/phonenumber.h 0e9bcfc 
>   agents/ontologies/nco/postaladdress.h 015f412 
>   agents/ontologies/nco/role.h 1f9642a 
>   agents/ontologies/nco/videoimaccount.h 696daaf 
>   agents/ontologies/nco/videotelephonenumber.h b1dafe9 
>   agents/ontologies/nco/voicephonenumber.h adbc5f9 
>   agents/ontologies/nmo/email.h 060154d 
>   agents/ontologies/nmo/immessage.h b331a24 
>   agents/ontologies/nmo/mailbox.h 5aec416 
>   agents/ontologies/nmo/mailboxdataobject.h 610520a 
>   agents/ontologies/nmo/message.h 6ac2f07 
>   agents/ontologies/nmo/messageheader.h 76a7aa1 
>   agents/ontologies/nmo/mimeentity.h 783ee49 
>   agents/strigifeeder/strigifeeder.cpp 7bb2715 
> 
> Diff: http://git.reviewboard.kde.org/r/104859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list