[Kde-pim] Review Request: KMail encountered a fatal error

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104477/#review13282
-----------------------------------------------------------


I think it would be better to separate the changes for the fix from the changes for style/krazy.
If down the road somebody looks at the diff in order to understand the fix they should not have to wade through all the unrelated changes


resources/maildir/configdialog.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10414>

    if you are also fixing coding style stuff, then you are missing a space between ( and ui.



resources/maildir/maildirresource.h
<http://git.reviewboard.kde.org/r/104477/#comment10423>

    why this change?



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10416>

    I think this does not belong here but in an "else" branch of the if (path.isEmpty())



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10417>

    when we reach this we have determined taht configFile is empty. thus mSettings->path() will be empty as well.
    This needs to be tested on the path retrieved from the collection



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10418>

    mSettings->topLevelIsContainer() is also at its default value (there is no config when we reach this)



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10415>

    I think in this case we will want to set "top level is container" to true, i.e. make the generated directory contain everything for that resource



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10419>

    hmm, what issue is krazy reporting here?



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10420>

    space between ( and fileInfo



resources/maildir/retrieveitemsjob.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10421>

    space between ( and index



resources/maildir/retrieveitemsjob.cpp
<http://git.reviewboard.kde.org/r/104477/#comment10422>

    spaces around entry


- Kevin Krammer


On May 2, 2012, 5:15 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104477/
> -----------------------------------------------------------
> 
> (Updated May 2, 2012, 5:15 p.m.)
> 
> 
> Review request for KDEPIM, Tobias Koenig, Volker Krause, and Kevin Krammer.
> 
> 
> Description
> -------
> 
> All the bugs get the Message: "KMail encountered a fatal error"
> This is now fixed.
> 
> This happens:
> - some situations with kmail1 and early kmail2 where a configuration file wasn't store properly.
> - the user deletes or looses a configuration file.
> 
> The first case was fixed by Tobias 2012-02-12.
> For the second case, kmail2 has now a procedure to repair the configuration.
> 
> In fact, the bug doesn't occur at kmail2 but at akonadi_agent_launcher as a resource wll be build, even if the configuration file 
> (such as "akonadi_maildir_resource_0rc") is missing.
> This will be now detected and repaired.
> Thanks to Kevin for choaching.
> 
> 
> This addresses bugs 124111, 218278, 246027, 250747, 258927, 259355, 259355, 277530, 284748, 286264, 286652, 290159, and 292384.
>     http://bugs.kde.org/show_bug.cgi?id=124111
>     http://bugs.kde.org/show_bug.cgi?id=218278
>     http://bugs.kde.org/show_bug.cgi?id=246027
>     http://bugs.kde.org/show_bug.cgi?id=250747
>     http://bugs.kde.org/show_bug.cgi?id=258927
>     http://bugs.kde.org/show_bug.cgi?id=259355
>     http://bugs.kde.org/show_bug.cgi?id=259355
>     http://bugs.kde.org/show_bug.cgi?id=277530
>     http://bugs.kde.org/show_bug.cgi?id=284748
>     http://bugs.kde.org/show_bug.cgi?id=286264
>     http://bugs.kde.org/show_bug.cgi?id=286652
>     http://bugs.kde.org/show_bug.cgi?id=290159
>     http://bugs.kde.org/show_bug.cgi?id=292384
> 
> 
> Diffs
> -----
> 
>   resources/maildir/configdialog.cpp 1ca4c79 
>   resources/maildir/libmaildir/keycache.cpp 83641df 
>   resources/maildir/libmaildir/maildir.h 8de40c3 
>   resources/maildir/libmaildir/maildir.cpp e64fb91 
>   resources/maildir/libmaildir/tests/testmaildir.cpp f7ecd73 
>   resources/maildir/maildirresource.h 41f35b5 
>   resources/maildir/maildirresource.cpp e8134fb 
>   resources/maildir/retrieveitemsjob.cpp c87c7b7 
>   resources/maildir/tests/synctest.cpp 2d13287 
> 
> Diff: http://git.reviewboard.kde.org/r/104477/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/