[Kde-pim] Review Request: Cleanup coding style other the directory kdepim-runtime/maildir/

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104864/#review13471
-----------------------------------------------------------



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10600>

    move to previous line



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10601>

    (qint64) is not a function call but a C style cast, so not spaces in there.
    What you could do instead is
    qint64( 8000 )
    i.e. calling the qint64 "constructor"



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10602>

    I think
    QLatin1Char( '.' )
    would be even better



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10603>

    I think you can make those other ifs into else ifs, i.e. flag cannot be Forwarded and Replied, etc



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10604>

    Make that a Q_FOREACH for consistency
    and const QString &keys (moving the & towards the variable name)



resources/maildir/maildirresource.h
<http://git.reviewboard.kde.org/r/104864/#comment10605>

    this should not be here, it is for an unrelated change



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10606>

    you can else if that one, "part" cannot start with two different prefixes at the same time



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10607>

    remove the space after item, i.e.
    Item item( items.at( 0 ) );



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10608>

    move & towards variable name, i.e.
    const Item::Flag &flag



resources/maildir/retrieveitemsjob.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10609>

    move & toward variable name



resources/maildir/retrieveitemsjob.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10610>

    } else {



resources/maildir/retrieveitemsjob.cpp
<http://git.reviewboard.kde.org/r/104864/#comment10611>

    }


- Kevin Krammer


On May 5, 2012, 2:37 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104864/
> -----------------------------------------------------------
> 
> (Updated May 5, 2012, 2:37 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Cleanup coding style other the directory kdepim-runtime/maildir/
> Note: NO signature where changed
> 
> Changing all the occurences of,
> from                 to
> ! expression         !expression
> ))                   ) )
> ){                   ) {
> if(                  if (
> foreach(             foreach (
> do{                  do {
> }while               } while
> ("string")           ( "string" ) 
> (expression)         ( expression ) 
> space at the end of a line
> 
> 
> Diffs
> -----
> 
>   resources/maildir/configdialog.cpp 1ca4c79 
>   resources/maildir/libmaildir/keycache.cpp 83641df 
>   resources/maildir/libmaildir/maildir.h 8de40c3 
>   resources/maildir/libmaildir/maildir.cpp e64fb91 
>   resources/maildir/libmaildir/tests/testmaildir.cpp f7ecd73 
>   resources/maildir/maildirresource.h 41f35b5 
>   resources/maildir/maildirresource.cpp e8134fb 
>   resources/maildir/retrieveitemsjob.cpp c87c7b7 
>   resources/maildir/tests/synctest.cpp 2d13287 
> 
> Diff: http://git.reviewboard.kde.org/r/104864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/