[Kde-pim] Review Request: Cleanup coding style other the directory kdepim-runtime/agents/

Kevin Krammer krammer at kde.org
Wed May 9 17:42:48 BST 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104859/#review13610
-----------------------------------------------------------



agents/nepomukfeeder/dms-copy/createresourcejob.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10804>

    file from dms-copy, ignore



agents/nepomukfeeder/dms-copy/datamanagement.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10805>

    file from dms-copy, ignore



agents/nepomukfeeder/feederqueue.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10803>

    Why the change in the comment?
    addGraphToNepomuk -> removeDataByApplication?



kresources/kabc/resourceakonadi.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10806>

    No, this code uses this specific debug area on purpose



kresources/kcal/resourceakonadi.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10807>

    Also no, again this code uses this debug area on purpose



kresources/shared/abstractsubresourcemodel.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10809>

    Using this debug area on purpose



migration/kmail/abstractcollectionmigrator.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10811>

    A cast again:
    = static_cast<SpecialMailCollections::Type>( type );



migration/kmail/kmailmigrator.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10812>

    cast



migration/kmigratorbase.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10810>

    This is a cast so space in () does not apply.
    But correct fix would be to use a C++ style cast:
    = static_cast<MigrationState>( e.keyTovalue( s.toLatin1() ) );



plugins/kaeventformatter.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10813>

    ignore this file, this is basically part of KAlarm and has a different coding style



resources/imap/addcollectiontask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10814>

    As volker pointed out earlier there is no point in changing that



resources/imap/additemtask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10815>

    Debug area 5327 used on purpose in Imap resource classes



resources/imap/retrievecollectionmetadatatask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10816>

    See earlier comment



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10817>

    maintainer prefers the original style for better readability



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10818>

    see above



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10819>

    see above



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10820>

    see above



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10821>

    see earlier comment



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/104859/#comment10822>

    see earlier comment


- Kevin Krammer


On May 7, 2012, 5:25 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104859/
> -----------------------------------------------------------
> 
> (Updated May 7, 2012, 5:25 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Cleanup coding style other the directory kdepim-runtime/agents/
> Note: NO signature where changed
> 
> Changing all the occurences of,
> from                 to
> ! expression         !expression
> ))                   ) )
> ){                   ) {
> if(                  if (
> foreach(             foreach (
> for(                 for (
> do{                  do {
> }while               } while
> ("string")           ( "string" ) 
> (expression)         ( expression ) 
> space at the end of a line
> 
> 
> Diffs
> -----
> 
>   resources/openxchange/oxa/oxutils.cpp 6604dc3 
>   resources/pop3/accountdialog.cpp 2aa7b34 
>   resources/pop3/pop3resource.cpp 3910f32 
>   resources/pop3/settings.cpp 3f1eb4a 
>   resources/shared/collectionannotationsattribute.cpp b4df346 
>   resources/shared/imapaclattribute.cpp ebd8f47 
>   resources/shared/imapquotaattribute.cpp 1747c03 
>   resources/openxchange/openxchangeresource.cpp 8624955 
>   resources/nntp/settings.cpp 793ba42 
>   resources/openxchange/configdialog.cpp a30eab4 
>   resources/nntp/configdialog.cpp 511ce12 
>   resources/nntp/nntpresource.cpp 1cff03b 
>   resources/mixedmaildir/tests/collectionfetchtest.cpp 7c5f6af 
>   resources/mixedmaildir/tests/collectionmodifytest.cpp b9a1afb 
>   resources/mixedmaildir/tests/collectiondeletetest.cpp 841bd2f 
>   resources/mixedmaildir/kmindexreader/tests/testidxreader.cpp 20c1552 
>   resources/mixedmaildir/mixedmaildirresource.cpp a345dc8 
>   resources/mixedmaildir/mixedmaildirstore.cpp 85711d1 
>   agents/invitations/incidenceattribute.h 3c5b6df 
>   agents/invitations/incidenceattribute.cpp ab4887d 
>   agents/invitations/invitationsagent.cpp 339a6ee 
>   agents/maildispatcher/maildispatcheragent.cpp 1be32e9 
>   agents/maildispatcher/outboxqueue.cpp 8cef358 
>   agents/maildispatcher/sendjob.cpp 7d57135 
>   agents/maildispatcher/storeresultjob.cpp 032aa14 
>   agents/maildispatcher/tests/aborttest.cpp c35be48 
>   agents/maildispatcher/tests/dupetest.cpp d76451e 
>   agents/nepomukfeeder/dms-copy/createresourcejob.cpp d2195fb 
>   agents/nepomukfeeder/dms-copy/datamanagement.cpp aedf54f 
>   agents/nepomukfeeder/feederqueue.h 9c55fc1 
>   agents/nepomukfeeder/feederqueue.cpp fc7d399 
>   agents/nepomukfeeder/nepomukfeederagent.h e1390fc 
>   agents/nepomukfeeder/nepomukfeederagent.cpp c407b76 
>   agents/nepomukfeeder/nepomukhelpers.h 7aea22b 
>   agents/nepomukfeeder/nepomukhelpers.cpp 5c99d04 
>   agents/nepomukfeeder/plugin/nepomukfeederutils.cpp 6875230 
>   agents/nepomukfeeder/pluginloader.cpp b3b79b0 
>   agents/nepomukfeeder/plugins/nepomukcalendarfeeder.cpp dfca991 
>   agents/nepomukfeeder/plugins/nepomukcontactfeeder.cpp 241792d 
>   agents/nepomukfeeder/plugins/nepomukmailfeeder.cpp 0a6980b 
>   agents/nepomukfeeder/plugins/nepomuknotefeeder.cpp 04f0af6 
>   agents/nepomukfeeder/test/akonadinepomukfeeder_indexer.cpp a66000c 
>   agents/newmailnotifier/newmailnotifieragent.cpp dbae8c7 
>   agents/strigifeeder/strigifeeder.cpp 7bb2715 
>   kcm/configmodule.cpp d92907c 
>   kcm/resourcesmanagementwidget.cpp fad000e 
>   kcm/serverconfigmodule.cpp 930b6c8 
>   kioslave/akonadislave.cpp 7ecbfad 
>   kresources/kabc/resourceakonadi.cpp 39edf6e 
>   kresources/kabc/resourceakonadi_p.cpp be0fa85 
>   kresources/kabc/subresource.cpp 77a829f 
>   kresources/kcal/resourceakonadi.cpp 16524f3 
>   kresources/kcal/resourceakonadi_p.cpp 3a825a5 
>   kresources/kcal/subresource.cpp 79b294c 
>   kresources/shared/abstractsubresourcemodel.cpp 78415ea 
>   kresources/shared/concurrentjobs.cpp 0faa0d1 
>   kresources/shared/itemsavejob.cpp 4a12e64 
>   kresources/shared/resourceconfigbase.cpp b3ab2cc 
>   kresources/shared/resourceprivatebase.cpp 0eca57c 
>   kresources/shared/storecollectionmodel.cpp 22e3945 
>   kresources/shared/subresourcebase.cpp e4c8a89 
>   kresources/shared/subresourcemodel.h 956a0ff 
>   libkdepim-copy/diffalgo.cpp f632eef 
>   libkdepim-copy/htmldiffalgodisplay.cpp 59be1d6 
>   migration/entitytreecreatejob.cpp 90988fd 
>   migration/kaddressbook/kaddressbookmigrator.cpp dc635b7 
>   migration/kjots/kjotsmigrator.cpp 1ef93b3 
>   migration/kmail/abstractcollectionmigrator.cpp 991c630 
>   migration/kmail/emptyresourcecleaner.h f7fe7d1 
>   migration/kmail/emptyresourcecleaner.cpp 9c45a72 
>   migration/kmail/imapcacheadapter.cpp b43fda9 
>   migration/kmail/imapcachecollectionmigrator.h 9304bb9 
>   migration/kmail/imapcachecollectionmigrator.cpp 88b84f6 
>   migration/kmail/imapcachelocalimporter.cpp bb41246 
>   migration/kmail/kmailmigrator.h 367b3e2 
>   migration/kmail/kmailmigrator.cpp 92f0dd8 
>   migration/kmail/localfolderscollectionmigrator.cpp ea9f163 
>   migration/kmail/main.cpp 3f1bb1e 
>   migration/kmigratorbase.h cdc781c 
>   migration/kmigratorbase.cpp 9318c8e 
>   migration/kres/kabcmigrator.cpp ad4701f 
>   migration/kres/kcalmigrator.cpp 8d3e106 
>   migration/kres/knotesmigrator.cpp d7b6ea5 
>   migration/kres/kresmigrator.h 639060a 
>   migration/kres/main.cpp 47f3afe 
>   migration/tests/testnotesmigration.cpp a928f5f 
>   opensync/akonadi_opensync.cpp c227a04 
>   opensync/akonadisink.cpp 66c7f95 
>   opensync/datasink.cpp e2c7849 
>   opensync/sinkbase.cpp 4da295a 
>   plugins/akonadi_serializer_contactgroup.cpp faab74b 
>   plugins/akonadi_serializer_microblog.cpp 937c6f5 
>   plugins/kaeventformatter.cpp f4a15cc 
>   resources/birthdays/configdialog.cpp 5f1e345 
>   resources/contacts/contactsresource.cpp 547e9c9 
>   resources/dav/common/davcollectionmodifyjob.cpp 64cb534 
>   resources/dav/common/davprincipalsearchjob.cpp 1f79f3e 
>   resources/dav/resource/replaycache.h 65384bb 
>   resources/ical/shared/icalresource.cpp 8cc8e7c 
>   resources/ical/shared/icalresourcebase.h d17d659 
>   resources/imap/addcollectiontask.cpp 81c7dd9 
>   resources/imap/additemtask.cpp 904046b 
>   resources/imap/changecollectiontask.cpp 727f004 
>   resources/imap/changeitemtask.cpp a5a09ec 
>   resources/imap/expungecollectiontask.cpp 640caaf 
>   resources/imap/imapidlemanager.cpp 32a37d4 
>   resources/imap/imapresource.cpp 17f4561 
>   resources/imap/moveitemtask.cpp 2bab48e 
>   resources/imap/removecollectionrecursivetask.cpp d51eace 
>   resources/imap/removecollectiontask.cpp 552da02 
>   resources/imap/resourcetask.cpp a573cc5 
>   resources/imap/retrievecollectionmetadatatask.cpp 3fae20b 
>   resources/imap/retrievecollectionstask.cpp 0b0f635 
>   resources/imap/retrieveitemstask.cpp 16fab79 
>   resources/imap/retrieveitemtask.cpp 035f279 
>   resources/imap/sessionuiproxy.h b5fea7b 
>   resources/imap/settingspasswordrequester.h a845513 
>   resources/imap/setupserver.cpp e7d3a5a 
>   resources/imap/subscriptiondialog.cpp dd369a0 
>   resources/imap/tests/dummypasswordrequester.cpp 9574c50 
>   resources/imap/tests/imaptestbase.h 141c739 
>   resources/imap/tests/testaddcollectiontask.cpp f356401 
>   resources/imap/tests/testadditemtask.cpp ebd74ba 
>   resources/imap/tests/testchangecollectiontask.cpp fd191d8 
>   resources/imap/tests/testchangeitemtask.cpp ab079c2 
>   resources/imap/tests/testexpungecollectiontask.cpp 1cb95f2 
>   resources/imap/tests/testmovecollectiontask.cpp fc6801c 
>   resources/imap/tests/testmoveitemtask.cpp e0950da 
>   resources/imap/tests/testremovecollectiontask.cpp 9a3152a 
>   resources/imap/tests/testremoveitemtask.cpp 531a1ad 
>   resources/imap/tests/testresourcetask.cpp e5671b1 
>   resources/imap/tests/testretrievecollectionmetadatatask.cpp c21b9f0 
>   resources/imap/tests/testretrievecollectionstask.cpp f9c1792 
>   resources/imap/tests/testretrieveitemstask.cpp fffd7e9 
>   resources/imap/tests/testretrieveitemtask.cpp f2e3323 
>   resources/imap/tests/testsessionpool.cpp 318c5f2 
>   resources/kabc/kabcresource.cpp 52e97f6 
>   resources/kabc/kresourceassistant.cpp e62ac93 
>   resources/kalarm/kalarm/kalarmresource.h f581cad 
>   resources/kalarm/kalarm/kalarmresource.cpp 4fcc84f 
>   resources/kcal/kcalresource.cpp 0ffa9ec 
>   resources/knut/knutresource.cpp 9a4bb34 
>   resources/kolabproxy/addressbookhandler.cpp 1a3b0b9 
>   resources/kolabproxy/contact.cpp e421629 
>   resources/kolabproxy/freebusyupdatehandler.cpp 3b182c2 
>   resources/kolabproxy/incidencehandler.cpp 548842b 
>   resources/kolabproxy/journalhandler.cpp b2e54fb 
>   resources/kolabproxy/kolabhandler.cpp aff972f 
>   resources/kolabproxy/kolabproxyresource.cpp 0b4b5b4 
>   resources/kolabproxy/notehandler.cpp 44471fd 
>   resources/kolabproxy/setupdefaultfoldersjob.cpp 00efa71 
>   resources/kolabproxy/setupkolab.cpp 6ef5ec9 
>   resources/kolabproxy/tests/kolabconvertertest.cpp b0d3a1f 
>   resources/localbookmarks/localbookmarksresource.cpp 50dcba7 
>   resources/maildir/configdialog.cpp 1ca4c79 
>   resources/maildir/libmaildir/keycache.cpp 83641df 
>   resources/maildir/libmaildir/maildir.h 8de40c3 
>   resources/maildir/libmaildir/maildir.cpp e64fb91 
>   resources/maildir/libmaildir/tests/testmaildir.cpp f7ecd73 
>   resources/maildir/maildirresource.h 41f35b5 
>   resources/maildir/maildirresource.cpp e8134fb 
>   resources/maildir/retrieveitemsjob.cpp c87c7b7 
>   resources/maildir/tests/synctest.cpp 2d13287 
>   resources/mailtransport_dummy/configdialog.cpp f51eb66 
>   resources/mailtransport_dummy/mtdummyresource.cpp 192874a 
>   resources/mbox/mboxresource.cpp 667468e 
>   resources/microblog/configdialog.cpp 7cbbe70 
>   resources/mixedmaildir/configdialog.cpp f3dd967 
>   resources/mixedmaildir/kmindexreader/kmindexreader.cpp c28d656 
> 
> Diff: http://git.reviewboard.kde.org/r/104859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list