[Kde-pim] EntityTreeModelPrivate::retrieveAncestors won't work

[Dan Vratil]

On Thursday 24 of May 2012 15:59:38 Alex Fiestas wrote:
> When a DAV resource is added and address/organizer are executed the new
> collections won't be shown until the application is restarted. 

I've run to this issue with the Google resources and I managed to work around 
it by adding mime types of child collections to the parent collection. 

So the problem might lie somewhere else then in the code you mentioned below. 
I'd guess it would be the monitor, which does not check child collections if 
their parent does not match the mime type filter or something like that (just 
a wild guess).

Cheers,

Dan

> Trying to fix
> that bug I have arrived to:
> 
> entitytreemodel_p.cpp:616
> EntityTreeModelPrivate::retrieveAncestors
> 
> In that method one of the first thing done is fetch all the ancestors by
> doing:
> 
> while ( !m_collections.contains( parentCollection.id() ) ) {
> 	parentCollection = parentCollection.parentCollection();
> 
> Which makes total sense.
> 
> The problem is that, just after it we are doing the follow comparation:
> if ( parentCollection == m_rootCollection ) {
> 	return;
> }
> 
> I don't understand much about the whole akonadi system yet (working on it)
> but my logic says that conditional is going to be always true because of
> the while and applications setting Akonadi::Collection::root as the
> CollectionMonitored (ChangeRecorder::setCollectionMonitored).
> 
> Took a look at the commit message but couldn't understand the reason why
> this conditional was added :/
> 
> Any feedback / ideas / something ?
> 
> Thanks !
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/
-- 
Dan Vratil
www.progdan.cz | dan at progdan.cz | Jabber: progdan at jabber.cz
Fingerprint: 76C9 2F08 5D0D 6F9E 5AD4 2BFD 3A85 0307 F506 5B61
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20120525/6e4e4365/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/