[Kde-pim] Review Request: Fix hang when ktimetracker quits after creating kpart failed

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104929/#review13768
-----------------------------------------------------------


Looks good to me.
However I am wondering if a better way of exiting would be to do a kFatal() logging.

Thorsten, any preference?

- Kevin Krammer


On May 13, 2012, 2:56 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104929/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 2:56 a.m.)
> 
> 
> Review request for KDEPIM and Thorsten Staerk.
> 
> 
> Description
> -------
> 
> KTimeTracker hanged after displaying either "Could not create the KTimeTracker part."  or "Could not find the KTimeTracker part." and never quit. This fixes it.
> 
> 
> Diffs
> -----
> 
>   ktimetracker/mainwindow.cpp abb3747 
> 
> Diff: http://git.reviewboard.kde.org/r/104929/diff/
> 
> 
> Testing
> -------
> 
> Compiled and checked it doesn't hang anymore.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/