[Kde-pim] Review Request: Increase the column size for the queryString to 32768

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104902/#review13644
-----------------------------------------------------------

Ship it!


looks good to me, thanks!

- Volker Krause


On May 9, 2012, 11:50 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104902/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 11:50 p.m.)
> 
> 
> Review request for Akonadi and Volker Krause.
> 
> 
> Description
> -------
> 
> Make the query string column wide enough for Sparql queries.
>     
> Ideally we would be using BLOB, but that is a bit of a pain to add (would require to alter the whole mapping of Qt-Datatypes, or use some magic value), and 32000 should be big enough for any sane query.
> As an extra there is now a safety check for oversized queries, so we don't get truncated queries executed.
> 
> 
> Diffs
> -----
> 
>   server/src/search/nepomuksearchengine.cpp 341c2d9be770896ba6c4739d59be6e4a1a87a17c 
>   server/src/search/searchmanager.cpp 334edf5ed14c580a3e4045b2af241c1c0f627937 
>   server/src/storage/akonadidb.xml 7d9e089ae3bce20690ab50485f0649d8c2da32eb 
>   server/src/storage/dbupdate.xml 7991de8d4d7e0d134bdafb4637aa84e1e7238649 
>   server/tests/unittest/dbinitializertest_data/mysql_ct_collection c1ec3a45fd43207664e6b8412365d045ac99c17b 
>   server/tests/unittest/dbinitializertest_data/odbc_ct_collection 30e52b9eaddf3dd8d1d23005a7b1df83d78fe628 
>   server/tests/unittest/dbupdatertest.cpp 1cdc04ff6b885330f785c0352d2b443569338838 
> 
> Diff: http://git.reviewboard.kde.org/r/104902/diff/
> 
> 
> Testing
> -------
> 
> unittests, tried it with kmail.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/