[Kde-pim] Review Request: Query nepomuk directly for address completion, in addition to akonadi and ldap search

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104404/#review11837
-----------------------------------------------------------



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9382>

    should probably also be #ifndef with KDEPIM_NO_NEPOMUK for consistence with all other related parts



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9383>

    unrelated change :)
    if we should check this here, then IMHO it should be
    check timer
      create timer
    check search
      create search



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9384>

    Maybe some KUIT markup to indicate that it is a title of some sort, e.g.
    @title or @title:group
    
    Without translators might think it is a result string missing the numerical argument ("4 Contacts foudn in your data")



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9385>

    I think KDEPIM coding style preferes braces even for single line bodies



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9386>

    braces



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9387>

    hmm, maybe also log the search string?



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9388>

    const reference, unless you need to call non-const methods on result



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9389>

    alternatively just
    contact.insertEmail( email );



libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/104404/#comment9390>

    isn't that always true?


- Kevin Krammer


On March 25, 2012, 12:41 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104404/
> -----------------------------------------------------------
> 
> (Updated March 25, 2012, 12:41 p.m.)
> 
> 
> Review request for KDEPIM, Volker Krause and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> The results are added to the end, as a new section called "Contacts
> found in your data", after any hits that come in through akonadi,
> from addressbooks or from LDAP. They are relatively noisy, but still
> useful in situations where you are trying to find someone you don't have
> in your address books but have had dealings with in the past. In a
> brighter future we might replace the whole completion thing with one
> based on pimo:person, once we have meta contact merging and such in
> place. For now, this is a first step.
> 
> 
> Diffs
> -----
> 
>   libkdepim/CMakeLists.txt 2b783b5 
>   libkdepim/addresseelineedit.h feda1b0 
>   libkdepim/addresseelineedit.cpp f76a611 
> 
> Diff: http://git.reviewboard.kde.org/r/104404/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Adam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/