[Kde-pim] Review Request: Do not add an organizer to appointments without attendees

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104368/#review11757
-----------------------------------------------------------



incidenceeditor-ng/incidencedefaults.cpp
<http://git.reviewboard.kde.org/r/104368/#comment9322>

    With that ifdef enabled the Organizer would be added as an attendee.
    So you no longer would have an organizer for an incidence without attendees.
    
    Please move that ifdefed part out of the !mAttendees.empty() part so that this behavior would stay unchanged.


- Andre Heinecke


On March 22, 2012, 3:27 p.m., Stephan Diestelhorst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104368/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 3:27 p.m.)
> 
> 
> Review request for KDEPIM and Sergio Luis Martins.
> 
> 
> Description
> -------
> 
> Do not add an organizer to an appointment if there are no attendees present.  Fixed in those locations where it was actually triggered for an appointment that did not have any attendees.  Makes the resulting appointmes editale in Google Calendar and on Android phones.
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidenceattendee.cpp 00a86e05507edc86999671eca4f94bbc5d1d07ec 
>   incidenceeditor-ng/incidencedefaults.cpp 36f67c9b824b38ea50058c9a7ea2d0879a972178 
> 
> Diff: http://git.reviewboard.kde.org/r/104368/diff/
> 
> 
> Testing
> -------
> 
> Created several appointments to check that they become editable.  Modified appointments on both phone and KOrganizer and checked they would update on the other respective end.
> 
> 
> Thanks,
> 
> Stephan Diestelhorst
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/