[Kde-pim] Review Request: making kmail network-aware

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102431/#review11072
-----------------------------------------------------------

Ship it!


Ship It!

- Laurent Montel


On March 1, 2012, 9:44 p.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102431/
> -----------------------------------------------------------
> 
> (Updated March 1, 2012, 9:44 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Changes Solid calls to not render KMail useless when Solid can't detect network connection (same as Andreas did in isOffline). Asks the user to go online only based on the internal Kmail networkState status, ignoring the status of the network. Modifies behaviour of askToGoOnline() function to return false when there is no network detected, thus making checkMailOnStartup() and checkMail() functions network-aware.
> 
> 
> Diffs
> -----
> 
>   kmail/kmkernel.h 35eaf28 
>   kmail/kmkernel.cpp 86244a6 
>   kmail/kmmainwidget.h f9c59a2 
>   kmail/kmmainwidget.cpp 06bdb0e 
> 
> Diff: http://git.reviewboard.kde.org/r/102431/diff/
> 
> 
> Testing
> -------
> 
> compiles,runs, works fine with solid not detecting network, haven't bumped into any issue with Solid working.
> 
> 
> Thanks,
> 
> Martin Bednar
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/