[Kde-pim] Review Request: Add new "default" fields to KPIMIdentities::Identity

[Robert Mathias Marmorstein]

> On March 8, 2012, 9:30 a.m., Kevin Krammer wrote:
> > I am wondering if it would make more sense to return this additional data as a KABC::Addressee instead of adding getters for each new field.
> > Or allow to associate an addressbook entry which would then contain these details.
> 
> Robert Mathias Marmorstein wrote:
>     Is it just KABC::StdAddressBook which is deprecated, then?  I was afraid the whole KABC namespace was going away...
> 
> Kevin Krammer wrote:
>     Just StdAddressBook, AddressBook and KABC::Resource stuff.
>     KABC::Addressee is still the main data object for contacts, they are just loaded and saved differently
> 
> Robert Mathias Marmorstein wrote:
>     I see.  In that case, KABC::Addressee (and KABC::PhoneNumber) are definitely the way to go.

Okay, ran into some problems: I can't seem to #include <addressee.h> from the identities code.  No matter what I do with CMakeLists.txt, it keeps complaining that it can't find "address.h" (not the same as as addressee.h).  I think the problem has to do with the fact that addressee.h seems to be generated code, but it's got me completely hung up.

Any suggestions?


- Robert Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104181/#review11229
-----------------------------------------------------------


On March 7, 2012, 11:34 p.m., Robert Mathias Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104181/
> -----------------------------------------------------------
> 
> (Updated March 7, 2012, 11:34 p.m.)
> 
> 
> Review request for KDEPIM and KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> The KABC::StdAddressBook class has been deprecated and KPIMIdentities is the suggested replacement.  Unfortunately, many of the fields that were available in StdAddressBook are missing in the Identity class.  It's possible to use the property() and setProperty() methods to store custom fields, but that means that different apps might use different field names for things like home phone number and locality (city).  
> 
> We use this functionality in KOffice to store information about the document author.  Internally, we can just use the property methods, but it would be nice to have interoperability with other applications (such as KAddressBook).  
> 
> This patch adds methods for accessing some of the missing fields (the ones we use in KOffice).  Some of the functionality of StdAddressBook is still missing -- instead of a list of phone numbers, I hardwired in a "Home" and "Work" phone number -- but it is a step forward.
> 
> This is code I am not that familiar with, but it seems pretty straightforward.  I welcome any comments/constructive criticism.
> 
> 
> Diffs
> -----
> 
>   kpimidentities/identity.h b0d0e7c 
>   kpimidentities/identity.cpp e1023b3 
> 
> Diff: http://git.reviewboard.kde.org/r/104181/diff/
> 
> 
> Testing
> -------
> 
> kdepimlibs compiles and passes the same unit tests it did before the change.  Unfortunately, I just switched my main development computer to Kubuntu from Archlinux (which made testing library changes very easy) and am still trying to figure out the best way to test library changes without clobbering the system packages.  Any suggestions/help would be much appreciated.
> 
> 
> Thanks,
> 
> Robert Mathias Marmorstein
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/