[Kde-pim] Review Request: more compact kaddressbook layout

[Jonathan Marten]

> On March 18, 2012, 3:12 p.m., Allen Winter wrote:
> > I'm very happy to see this.  There are some coding style and missing KUIT things, but nothing I can't fix really easy for you.
> > 
> > Question: are the splitter layouts saved/restored properly in both 2 and 3 column modes now?
> > Also, do we need a update script to deal with the renaming of the modes?

Hmm, thought I'd tried to stick to the coding style and use i18nc() properly here (but just noticed that there are some "if (cond) single statement;" without braces, is this what you mean).  Are there any that I should fix before commit?

Splitter layouts are saved/restored individually for the 2 or 3 column modes (there is nothing to save for simple view).  The strategy is that the layout is saved when leaving a mode (which includes destruction) and restored when entering a mode (which includes startup), apart from the destruction this is concentrated in one single place in setViewMode().

I thought about the need for an update script, but was not sure how easy it would be to split up the one-splitter-3-panes configuration into two-splitters-each-with-2-panes, especially as part of the state seems to be a binary blob.  If there is no update, then the user just has to do some fairly simple splitter dragging the first time - hopefully not too annoying.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104308/#review11542
-----------------------------------------------------------


On March 16, 2012, 9:08 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104308/
> -----------------------------------------------------------
> 
> (Updated March 16, 2012, 9:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The main point raised by the addressed bug is the amount of screen space taken up by the KAddressBook GUI compared with the amount of useful contact information (the details pane).
> 
> This change implements a viewing mode halfway between the simple mode (which has the disadvantage that the list of contacts is not shown and so cannot be browsed by scrolling) and the 3-column full mode (which, unless the user has many address books, has a big blank space below the address book list).  This is done by simply putting the contacts list below the address book list.
> 
> A new "View" menu is added to select one of the three viewing modes, and also the "Show QR Codes" option.
> 
> The splitter sizes and positions are saved separately for the 2-column and 3-column modes.
> 
> 
> This addresses bug 291263.
>     http://bugs.kde.org/show_bug.cgi?id=291263
> 
> 
> Diffs
> -----
> 
>   kaddressbook/kaddressbook.kcfg 7120092 
>   kaddressbook/kaddressbookui.rc ec676ae 
>   kaddressbook/mainwidget.h eff2d66 
>   kaddressbook/mainwidget.cpp f00684c 
> 
> Diff: http://git.reviewboard.kde.org/r/104308/diff/
> 
> 
> Testing
> -------
> 
> Built KAddressBook with these changes, checked operation starting with a blank or existing configuration in all viewing modes.
> 
> 
> Screenshots
> -----------
> 
> 3 column view with new menu
>   http://git.reviewboard.kde.org/r/104308/s/471/
> 2 column view
>   http://git.reviewboard.kde.org/r/104308/s/472/
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/