[Kde-pim] Review Request: KMail encountered a fatal error

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104163/#review11146
-----------------------------------------------------------



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104163/#comment8973>

    This will always be true when the resource has just been created.
    Not sure if this is a problem though



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104163/#comment8974>

    The local KDE directory can be something else than $HOME/.kde and the filename depends on the number of already existing maildir resource (_0rc is only for the very first one).
    
    I think the filename should be derivable from the "id" parameter, the base path KStandardDirs::localkdedir()
    
    KStandardDirs::saveLocation() might be even more appropriate



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104163/#comment8975>

    See above.
    $HOME/.local/share is just the fallback used when $XDG_DATA_HOME is not set or empty. The variable can point to anywhere.
    
    Correct base path is KStandardDirs::localxdgdatadir()


- Kevin Krammer


On March 5, 2012, 5:16 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104163/
> -----------------------------------------------------------
> 
> (Updated March 5, 2012, 5:16 p.m.)
> 
> 
> Review request for KDEPIM, Tobias Koenig, Volker Krause, and Kevin Krammer.
> 
> 
> Description
> -------
> 
> As discussed in Osnabrück, I made my homework and fix the bug.
> At maildirresource.cpp:100 I include a test of mSettings->path()
> If empty, I propose to use as default the standard location, 
> write the configuration to the disk, ensure it is sane and create
> the directories.
> 
> 
> This addresses bug 259355.
>     http://bugs.kde.org/show_bug.cgi?id=259355
> 
> 
> Diffs
> -----
> 
>   resources/maildir/maildirresource.cpp e8134fb 
> 
> Diff: http://git.reviewboard.kde.org/r/104163/diff/
> 
> 
> Testing
> -------
> 
> remove the .kde/share/config/akonadi_maildir_resource_0rc and run again the 
> akonadi_maildispatcher_agent . The file will be creates again.
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/