[Kde-pim] Review Request: Changes to the KIMap::Session class to make it work a little better (and stop crashing)

[Allen Winter]

> On June 29, 2012, 2:06 p.m., Kevin Ottens wrote:
> >

Ok, I won't commit any of this.

Although it is working really well for me.  Maybe other fixes David is making elsewhere in the akonadi imap agent will help too.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105343/#review15255
-----------------------------------------------------------


On June 24, 2012, 11:09 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105343/
> -----------------------------------------------------------
> 
> (Updated June 24, 2012, 11:09 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Kevin Ottens, Volker Krause, David Faure, and Gregory Schlomoff.
> 
> 
> Description
> -------
> 
> This is my attempt at making the akonadi_imap_resource stop crashing in the Session class.
> 
> Changes are:
> * Undeprecate the call to connectionLost() using stateChanged() instead.
> 
> * Remove a call to connectionLost() that I can't understand why it's there in the first place (the comment says to wait until KDE5, but I don't see why we need to wait)
> 
> * assert null jobs (just in case) in addJob and jobDone
> 
> 
> Diffs
> -----
> 
>   kimap/session.cpp 9344d8e 
> 
> Diff: http://git.reviewboard.kde.org/r/105343/diff/
> 
> 
> Testing
> -------
> 
> Ran it for a few days.  I haven't seen problems or crashes in that time.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/