[Kde-pim] Review Request: Replace dms-copy by nepomuk-core

Vishesh Handa me at vhanda.in
Sat Jun 30 13:00:39 BST 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105393/#review15265
-----------------------------------------------------------



agents/nepomukfeeder/feederqueue.h
<http://git.reviewboard.kde.org/r/105393/#comment11921>

    Could you maybe use the fancy headers? They look nicer.
    
    #include <Nepomuk2/SimpleResourceGraph>
    
    If you don't want to, then that's cool.


- Vishesh Handa


On June 30, 2012, 11:15 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105393/
> -----------------------------------------------------------
> 
> (Updated June 30, 2012, 11:15 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Now that nepomuk-core is available we can finally get rid of our dms copy.
> This is also required for the dbus interfaces to work again, which I require in a nepomuk testing utility.
> 
> I did not yet replace the generated classes in agents/ontologies by actually generating the classes, so this patch only adjusts the includes and namespaces.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ebe5766f48a63e6abcf34e0947f6f1bd2d70fbbe 
>   agents/nepomukfeeder/CMakeLists.txt e7eb851afffe70c656800cc808c5f7e59dc19e20 
>   agents/nepomukfeeder/dms-copy/CMakeLists.txt ded053b254b4cfe695eda147cdb1db48a2ec7d46 
>   agents/nepomukfeeder/dms-copy/Doxyfile.cmake cf9d13ff2d31cb7a9088758bff0113eb86eb0e80 
>   agents/nepomukfeeder/dms-copy/README c907f860947dd43ba060990eca9de35f5d87fe53 
>   agents/nepomukfeeder/dms-copy/abstracttimeoutdbusinterface.h 3cd0f3fb3f0f243d62ac96888d137c8c765da472 
>   agents/nepomukfeeder/dms-copy/abstracttimeoutdbusinterface.cpp cc060d3a67f98a487e50c4e66755215faf924e40 
>   agents/nepomukfeeder/dms-copy/createresourcejob.h ed5a2c73d87b6235f227d0f2c214430025ba7516 
>   agents/nepomukfeeder/dms-copy/createresourcejob.cpp d2195fb4b1f528931230d7026a8c8531236409b3 
>   agents/nepomukfeeder/dms-copy/datamanagement.h 4c3cb90bc92bb2187211f7886d3998921fe3c9fd 
>   agents/nepomukfeeder/dms-copy/datamanagement.cpp aedf54f40b432b82fc9ee761dd9197ed8e47d7c4 
>   agents/nepomukfeeder/dms-copy/datamanagementinterface.h 615777011ee3c744959916d647575a483bb3d6d3 
>   agents/nepomukfeeder/dms-copy/datamanagementinterface.cpp 5019353441a7593032d49a23fcee4437d57de407 
>   agents/nepomukfeeder/dms-copy/dbustypes.h ce1e5789e68dad312c81177fc3914cb672e57f44 
>   agents/nepomukfeeder/dms-copy/dbustypes.cpp 09e5ddee37ba707602c616a200fbeca761ca3352 
>   agents/nepomukfeeder/dms-copy/describeresourcesjob.h c63c854fef43a00d22baa8dcef03b7fc02440ccc 
>   agents/nepomukfeeder/dms-copy/describeresourcesjob.cpp 5fd416542f249d22c0d25caf027de5c522d3c13d 
>   agents/nepomukfeeder/dms-copy/genericdatamanagementjob.cpp a5d38f43060f54767d18480f4384e1407d5ec996 
>   agents/nepomukfeeder/dms-copy/genericdatamanagementjob_p.h a741ad6e00281d0897539e165378893945255a06 
>   agents/nepomukfeeder/dms-copy/interfaces/org.kde.nepomuk.ResourceWatcher.xml 7f414443b976096de6903f7df0d357ba52f7e8e6 
>   agents/nepomukfeeder/dms-copy/interfaces/org.kde.nepomuk.ResourceWatcherConnection.xml 8b175bcdba45c697b2e6518f21ea5ae7cd8dffa0 
>   agents/nepomukfeeder/dms-copy/interfaces/resourcewatcherconnectioninterface.h afe91f9818df486d9b046d3f578bb20b00c662a9 
>   agents/nepomukfeeder/dms-copy/interfaces/resourcewatcherconnectioninterface.cpp 9a30db0580e74db95c6603beb39150fe94a2c84d 
>   agents/nepomukfeeder/dms-copy/interfaces/resourcewatchermanagerinterface.h 6a23eab9d342ec892274c817e82fd7c42397e616 
>   agents/nepomukfeeder/dms-copy/interfaces/resourcewatchermanagerinterface.cpp 8abe4f31ebe0df8486a989941714bad2df9ab0dc 
>   agents/nepomukfeeder/dms-copy/kdbusconnectionpool.h d4c7e9dce22b741fe11ae457807f0c2f3c0cf70f 
>   agents/nepomukfeeder/dms-copy/kdbusconnectionpool.cpp 43e1f5f27d03a41fa84a40433b6d5831ea0cd1a7 
>   agents/nepomukfeeder/dms-copy/nepomukdatamanagement_export.h 9921241a1b961b249ecae4fd81616d6bc679b300 
>   agents/nepomukfeeder/dms-copy/resourcewatcher.h ac4425d433f70e6fb81d8218df0931a789cb8ce8 
>   agents/nepomukfeeder/dms-copy/resourcewatcher.cpp f6fc93c2ebd75c1acc8d1f4a3d294009db670f03 
>   agents/nepomukfeeder/dms-copy/simpleresource.h f5d75632cec16b3754d058e29ee5bca4414128e5 
>   agents/nepomukfeeder/dms-copy/simpleresource.cpp 529396164f83ed787397b39b68880c1889d6fbc4 
>   agents/nepomukfeeder/dms-copy/simpleresourcegraph.h d897d4e6bd68fa35aedb382cfc0d1cd14349ea93 
>   agents/nepomukfeeder/dms-copy/simpleresourcegraph.cpp 41c4ee591450af975418c3daa688fc6051db3818 
>   agents/nepomukfeeder/dms-copy/storeresourcesjob.h 9043f3c0462b1505c5a6de72acdcb8df3b6fef96 
>   agents/nepomukfeeder/dms-copy/storeresourcesjob.cpp 592f28006b92f1b163b1dcf16965c7510e02de91 
>   agents/nepomukfeeder/feederqueue.h 1e1b4dbc1512fe95c550ba061e1ca7085e1e32d3 
>   agents/nepomukfeeder/feederqueue.cpp a7a0fc462e12c88e158d6dcf5375bdb279b18a4c 
>   agents/nepomukfeeder/nepomukfeederagent.cpp 9283e501d65e90469cb24d8c2ed444869a2c2fcd 
>   agents/nepomukfeeder/nepomukhelpers.h 4b1d21d17db70a650b05f92c445a95b5582d3d00 
>   agents/nepomukfeeder/nepomukhelpers.cpp 84badc00f9b4aea029db0e64ce17456c9bdef34e 
>   agents/nepomukfeeder/plugin/nepomukfeederplugin.h 209f031e6d8ecbeca3e789cee99430c766924d20 
>   agents/nepomukfeeder/plugin/nepomukfeederutils.h f8830c52b63e88dbcfe9374c05176e1f66cc4a69 
>   agents/nepomukfeeder/plugin/nepomukfeederutils.cpp fbd5a976b2c99a820e8c4a3e7ecee723cfa85f6a 
>   agents/nepomukfeeder/plugins/nepomukcalendarfeeder.h 6232e75262c09c6b8cbc7651c46085bf3388bb4f 
>   agents/nepomukfeeder/plugins/nepomukcalendarfeeder.cpp b6a656a1a320d16fd5d656c5e8940ebfbfeedc58 
>   agents/nepomukfeeder/plugins/nepomukcontactfeeder.h e8102e68448f8ba21314da70828efa226f75247c 
>   agents/nepomukfeeder/plugins/nepomukcontactfeeder.cpp f0d65e7fa6d8e515cb438623493843a5a401163d 
>   agents/nepomukfeeder/plugins/nepomukmailfeeder.h 81dfab91d8e9e601cd7afeadea87ee70a1e86cd8 
>   agents/nepomukfeeder/plugins/nepomukmailfeeder.cpp 04de23bd654324a5d7e96ddee0becb0ac6ee77eb 
>   agents/nepomukfeeder/plugins/nepomuknotefeeder.h ea9a1329808edcaf399b5e1a1ad87fc6ccfe7782 
>   agents/nepomukfeeder/plugins/nepomuknotefeeder.cpp 5626eb6d374563c3d81c30267aa7155991447e0c 
>   agents/nepomukfeeder/test/akonadinepomukfeeder_indexer.cpp 22720af3c0823fd017c324828ab7e85f8309c0e6 
>   agents/ontologies/CMakeLists.txt 2fea1e6fa44d92111da78481a2def7a34613e16a 
>   agents/ontologies/nao.tar.bz2 PRE-CREATION 
>   agents/ontologies/nao/agent.h ce089247565dbaa6ee3711c4a072f5c178968b06 
>   agents/ontologies/nao/freedesktopicon.h ab9cd03b2c2c5f96fb089275197f8e6eb259079c 
>   agents/ontologies/nao/party.h cd9240a3646d405a3705e9a5edbc7d7c0d364448 
>   agents/ontologies/nao/symbol.h a0ffcc7619d3facb4f1876bd43a86f3f235d0f88 
>   agents/ontologies/nao/tag.h 1be7b2187ddd7c0cfc83aa0b96e064dfb532a805 
>   agents/ontologies/ncal/accessclassification.h 15e1f1c34331f7e50b8d898cc656efcfaf698092 
>   agents/ontologies/ncal/alarm.h c7a88da614c29eb5f07945133327a630f08be4c9 
>   agents/ontologies/ncal/alarmaction.h ea7a468c13db401d4767e3ae4792676af2e3ff3e 
>   agents/ontologies/ncal/attachment.h 16391959dcfd1b4cbe87485261c01c1bd6c30fc9 
>   agents/ontologies/ncal/attachmentencoding.h a7be05697c8191914e004da0a24d5f15e42cc3c6 
>   agents/ontologies/ncal/attendee.h 11a9972fe4735feafb5cbeb66f3ed3800828dcfd 
>   agents/ontologies/ncal/attendeeororganizer.h 10738bf0b8a0982e8374f0583495aa8fd3e53bf8 
>   agents/ontologies/ncal/attendeerole.h 7c1276d3efece5bca4e741446624258195fe291e 
>   agents/ontologies/ncal/bydayrulepart.h a60e708448a7eb1b31d7aa95e49641bf275a3c89 
>   agents/ontologies/ncal/calendar.h 4a5fa740fa2c29dfc020cc2c50475faf2b894036 
>   agents/ontologies/ncal/calendardataobject.h a0099368c24436c5920c45297672d234b14c1ee9 
>   agents/ontologies/ncal/calendarscale.h 67d0a87ff1fe0c1f1a3b04057cdd2461d8f5dd47 
>   agents/ontologies/ncal/calendarusertype.h b575c0e7a1afacf27267e887e23a744d0bbddb30 
>   agents/ontologies/ncal/event.h 2c0c8e62edf4eedcb96211865571a90f36f95b3e 
>   agents/ontologies/ncal/eventstatus.h 6a7891e5e15d53b099fd681c8f7ecbfd29f01ee2 
>   agents/ontologies/ncal/freebusy.h 1d8d3c3ec9e62314077bdf899293be233af4f50c 
>   agents/ontologies/ncal/freebusyperiod.h 36eff2a08917ba15d1f26b33dd1e7f1dc7742277 
>   agents/ontologies/ncal/freebusytype.h 0cd2884c42a8fb4424c05298bd89d7b3db555451 
>   agents/ontologies/ncal/journal.h b1fca0722a7f6bc136cfe962f30d2374996682b9 
>   agents/ontologies/ncal/journalstatus.h c5569c464c4e7bec25f5077f2e8552ddb4dafde7 
>   agents/ontologies/ncal/ncaldatetime.h 28c7d78983183e1fa36512ffd66b7bbaa9af46c9 
>   agents/ontologies/ncal/ncalperiod.h 2715c2605127fc8098a7f1588f991ebc5c535865 
>   agents/ontologies/ncal/ncaltimeentity.h 6efbe4df5ee20ca3eaa87f7248d0b7f4cd430b9c 
>   agents/ontologies/ncal/organizer.h 39c7f30c8aebc1bc9050fa3f1c180e949b5be779 
>   agents/ontologies/ncal/participationstatus.h 7fd3c076fcf2227f6efa4af316702adb7a225ed7 
>   agents/ontologies/ncal/recurrencefrequency.h d95fd6d47cd7628c6b8cdf93dda63340bf96d53a 
>   agents/ontologies/ncal/recurrenceidentifier.h a1ca6b932cbf9f4a9922c130a33d249bdf4f1086 
>   agents/ontologies/ncal/recurrenceidentifierrange.h 72e34127c70ed0181f5538c0141d09f81349f6a4 
>   agents/ontologies/ncal/recurrencerule.h d54d62723164f4c5c20d0455f59fef8f70402c43 
>   agents/ontologies/ncal/requeststatus.h 478da6849c0e5599625461673e3399e33ffccac3 
>   agents/ontologies/ncal/timetransparency.h c67e9f2c96d6710a2f2a57aa42551d83aecea99a 
>   agents/ontologies/ncal/timezone.h 3e0b40774c590e1b016275f792a8b20f28e46b7f 
>   agents/ontologies/ncal/timezoneobservance.h 2dafb79f6e5fb7be367cc790e653c56cbef82f63 
>   agents/ontologies/ncal/todo.h b4ca361db90b8df4818f7bd164b97e53ca514f9a 
>   agents/ontologies/ncal/todostatus.h d06901808f30114ee1e573257f89fa7282d0fccf 
>   agents/ontologies/ncal/trigger.h 80fbd11798f8c5c4577994161994d6726d10a220 
>   agents/ontologies/ncal/triggerrelation.h 36f1c8b752c766c49eaf5d3e2ecff01e19b85dbc 
>   agents/ontologies/ncal/unionofalarmeventfreebusyjournaltodo.h 12af36bc5c090f956920a9f4c8119078c4af7801 
>   agents/ontologies/ncal/unionofalarmeventfreebusytodo.h 791cc4d5a7a925778d95d71cf0844a2128fe2252 
>   agents/ontologies/ncal/unionofalarmeventjournaltodo.h 4b15ce941c1e89a842ed80d631e059b1eba549e5 
>   agents/ontologies/ncal/unionofalarmeventtodo.h 5e25611315c75fb8f6d7938e6d57441b6417cb5b 
>   agents/ontologies/ncal/unionofeventfreebusy.h 68a8f671701da572afdc2da2aefb7653202e9fc9 
>   agents/ontologies/ncal/unionofeventfreebusyjournaltodo.h 144e63cbd5d46c3381a598e91175e9b7a0df5b9e 
>   agents/ontologies/ncal/unionofeventjournaltimezonetodo.h adf099ad7c5842571242f40a67962a3901e2e234 
>   agents/ontologies/ncal/unionofeventjournaltodo.h b2b0e603053f9694bd2ac6f8886f1b16098a7ba6 
>   agents/ontologies/ncal/unionofeventtodo.h c25c484ad657d20bfbce9b61f8a4a85c22d4f48b 
>   agents/ontologies/ncal/unionoftimezoneobservanceeventfreebusyjournaltimezonetodo.h 393541232f850512d48131c98bbeb82b1af70d8d 
>   agents/ontologies/ncal/unionoftimezoneobservanceeventfreebusytimezonetodo.h ef7b920e402cd3e74bf88cc48e6d526d0927185b 
>   agents/ontologies/ncal/unionoftimezoneobservanceeventjournaltimezonetodo.h 71c55e338e6e4fbc0a709b3fd934ed0efc3389a0 
>   agents/ontologies/ncal/unionparentclass.h 550d403704530fa8041a7f3fa25f5624260fed54 
>   agents/ontologies/ncal/weekday.h fa661976276711a21efc8b48581a142de3b35997 
>   agents/ontologies/nco/affiliation.h 10d35f85e12874b6ac88fa0f6167c0f566d65ba5 
>   agents/ontologies/nco/audioimaccount.h 400737b95eb956b5b4061e3d464162909ed9111c 
>   agents/ontologies/nco/bbsnumber.h d50dad23df17b6bdfb11c1e572ae42b42bfdbae9 
>   agents/ontologies/nco/carphonenumber.h 63a3b9420f2759c60854008b91588dc3769722ed 
>   agents/ontologies/nco/cellphonenumber.h 0f4c604411bebc5c211882f0bbe096300393e579 
>   agents/ontologies/nco/contact.h 842904a4383ab1f0db337a95e73092e89986d803 
>   agents/ontologies/nco/contactgroup.h 9e5f2a3f566bc740761f2b74388cc710e0df3c5d 
>   agents/ontologies/nco/contactlist.h 280b19259f822752e1b0692617e93d9e66db10ee 
>   agents/ontologies/nco/contactlistdataobject.h 54ef8720d427118f94ab9d8a5fadb6d948f7c8c4 
>   agents/ontologies/nco/contactmedium.h 4eaabc5b912cc818a5b19cbf13c63f305b8ab6f0 
>   agents/ontologies/nco/domesticdeliveryaddress.h 1dfd9adb6626c262333af4a247cc6a649fa6de67 
>   agents/ontologies/nco/emailaddress.h b50706bf7a4114d8c34ad30a638a815791b51f5b 
>   agents/ontologies/nco/faxnumber.h 6092cdd8d35163ea9b6d54fe119f6296ba80446e 
>   agents/ontologies/nco/gender.h 3f84560cf491fb0fb4002f08a34ccc1553654272 
>   agents/ontologies/nco/imaccount.h ca6eea7df0cb173d8913b5915e381048762c0e0b 
>   agents/ontologies/nco/imcapability.h d04cf124eb2794341e4384fa389e31a85c34864a 
>   agents/ontologies/nco/internationaldeliveryaddress.h b59550f74c9292390785d8039cbe23fa5059f959 
>   agents/ontologies/nco/isdnnumber.h 13af5e538428241033c6455133701c56de28d99e 
>   agents/ontologies/nco/messagingnumber.h a2d5fa5133f2d8e94aff80a37af1314bf995e52d 
>   agents/ontologies/nco/modemnumber.h 0b18b746b6ed0c9fa0fb044421efb77cbe574af7 
>   agents/ontologies/nco/organizationcontact.h 97d14f91b9093d52849b4e4988011f0fba867df5 
>   agents/ontologies/nco/pagernumber.h d8923bd271148d3340932addd51e2874dd732e56 
>   agents/ontologies/nco/parceldeliveryaddress.h 50d846a80b593eb43c24e396d39cf1ddef8cd1b8 
>   agents/ontologies/nco/pcsnumber.h 2b608be745909ec13d75e97933ead79aad81a386 
>   agents/ontologies/nco/personcontact.h b8aee201f2d99b4b5d6e665aadc24cadc072a213 
>   agents/ontologies/nco/phonenumber.h 0e9bcfc135f8a3796cd3e7facd052e2014fa1017 
>   agents/ontologies/nco/postaladdress.h 015f412b5907f8ec4820072992a60b0dfec5e799 
>   agents/ontologies/nco/role.h 1f9642a679521f3949917a95a77f896ad74de521 
>   agents/ontologies/nco/videoimaccount.h 696daafe6bd8c2b6083d7f4e34ac3c945d2c379b 
>   agents/ontologies/nco/videotelephonenumber.h b1dafe9d4f9fe76842f4cce3ba1be899311f756d 
>   agents/ontologies/nco/voicephonenumber.h adbc5f97742cf01d944da68c7acc62c70370b36b 
>   agents/ontologies/nmo/email.h 060154d86e3f50d71fd049db0966aa64ba90a3cf 
>   agents/ontologies/nmo/immessage.h b331a248808e80d203def935d70ebe0888ba6edb 
>   agents/ontologies/nmo/mailbox.h 5aec41617fdd02f357e92591262113d8e6f788e9 
>   agents/ontologies/nmo/mailboxdataobject.h 610520aa13a4000ceb8d0a80c31bf85188b534a4 
>   agents/ontologies/nmo/message.h 6ac2f076c464192e3dfa73a847032da7d10730ee 
>   agents/ontologies/nmo/messageheader.h 76a7aa185cc9033a2f24e4c5f3c67bf8bf02471f 
>   agents/ontologies/nmo/mimeentity.h 783ee490dcf12c90d107e21feab6170e53d1fc4e 
> 
> Diff: http://git.reviewboard.kde.org/r/105393/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list