[Kde-pim] Review Request: fix for some cppcheck and clang errors

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105149/
-----------------------------------------------------------

(Updated June 16, 2012, 8:14 a.m.)


Review request for KDEPIM.


Changes
-------

addressed the comments.
I've not been able to find the original commit of kjotsbrowser.cpp (using all git commands found googling).
Also, if you do not like all the fixes, you can say ship it for each file of the review.


Description
-------

1. change initialization order to follow variable declaration order
2. initialize the variable
3. do nothing if m is null.
4. adding a const bool to a const char* does not appends the value. Changed to QString with arg
5. add parenthesis to clarify ? expressions priority
6. add parenthesis to clarify ? expressions priority
7. add parenthesis to clarify || vs && priority
8. i++ to ++i (little faster)
9. add parenthesis to clarify || vs && priority
10. i++ to ++i (little faster)
11. avoid using tree if tree is null
12. avoid using extern "C" if the function return a class, incompatible C linkage (the comments are already removed)


Diffs (updated)
-----

  akonadi_next/kreparentingproxymodel.cpp 411e3fc 
  akregator/src/importfeedlistcommand.cpp 117237b 
  akregator/src/subscriptionlistview.cpp de41757 
  calendarsupport/next/incidencechanger2.cpp dd9fbd1 
  kaddressbook/printing/mikesstyle.cpp 1ac65cf 
  kalarm/lib/spinbox.cpp ab2e9ec 
  kjots/kjotsbrowser.cpp 3970cfc 
  kleopatra/smartcard/readerstatus.cpp 3b9c282 
  kleopatra/utils/gnupg-helper.cpp 02518db 
  kmail/undostack.cpp d981769 
  knode/foldertreewidget.cpp c0d1a92 
  plugins/ktexteditor/ktexteditorkabcbridge.cpp 050d478 

Diff: http://git.reviewboard.kde.org/r/105149/diff/


Testing
-------


Thanks,

Jaime Torres Amate

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/