[Kde-pim] Review Request: Do not add an organizer to appointments without attendees

Allen Winter winter at kde.org
Sun Jun 17 14:54:21 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104368/#review14809
-----------------------------------------------------------

Ship it!


Andre and Sergio and Kevin are ok with this patch.  And so am I.

- Allen Winter


On June 14, 2012, 9:54 p.m., Stephan Diestelhorst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104368/
> -----------------------------------------------------------
> 
> (Updated June 14, 2012, 9:54 p.m.)
> 
> 
> Review request for KDEPIM and Sergio Luis Martins.
> 
> 
> Description
> -------
> 
> Do not add an organizer to an appointment if there are no attendees present.  Fixed in those locations where it was actually triggered for an appointment that did not have any attendees.  Makes the resulting appointmes editale in Google Calendar and on Android phones.
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidenceattendee.cpp 00a86e05507edc86999671eca4f94bbc5d1d07ec 
>   incidenceeditor-ng/incidencedefaults.cpp 36f67c9b824b38ea50058c9a7ea2d0879a972178 
> 
> Diff: http://git.reviewboard.kde.org/r/104368/diff/
> 
> 
> Testing
> -------
> 
> Created several appointments to check that they become editable.  Modified appointments on both phone and KOrganizer and checked they would update on the other respective end.  Ran that now for 2 months, no ill-effects observed.
> 
> Any chance for upstream?
> 
> 
> Thanks,
> 
> Stephan Diestelhorst
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list