[Kde-pim] Review Request: Append, not prepend, items to CMAKE_MODULE_PATH

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105126/#review14345
-----------------------------------------------------------


since kdepimlibs installs a few FindFoo.cmake modules on its own, adjusting the CMAKE_MODULE_PATH to point to that installation location makes sense to me.  and prepending also makes sense.


Let's wait for krop to comment on this.

also you might consider adding the buildsystem group to this review so the CMake experts can take a look

- Allen Winter


On June 1, 2012, 11:02 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105126/
> -----------------------------------------------------------
> 
> (Updated June 1, 2012, 11:02 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Append, not prepend, items to CMAKE_MODULE_PATH
> 
> In KdepimLibsConfig.cmake, we previously prepended the cmake module path
> to CMAKE_MODULE_PATH.  This could interfere with projects that want to
> override a FindFoo.cmake script from this location (eg: provided by some
> KDE package) with one in their own source tree.
> 
> For example, it can break the build of Calligra which has a
> FindMarble.cmake script that is incompatible with one provided by some
> other KDE software.
> 
> (Question: why is this line even needed?)
> 
> 
> Diffs
> -----
> 
>   KdepimLibsConfig.cmake.in 8acbc6c0712f7536620226eb954edaf62b0d28da 
> 
> Diff: http://git.reviewboard.kde.org/r/105126/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/