[Kde-pim] Review Request: Fix cross-resource collection moving

[Volker Krause]

> On July 7, 2012, 3:51 p.m., Kevin Krammer wrote:
> > akonadi/agentbase_p.h, line 102
> > <http://git.reviewboard.kde.org/r/105474/diff/1/?file=71763#file71763line102>
> >
> >     not binary compatible
> >     http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_access_rights

Sure, but this is not public API.


> On July 7, 2012, 3:51 p.m., Kevin Krammer wrote:
> > akonadi/recursivemover.cpp, line 154
> > <http://git.reviewboard.kde.org/r/105474/diff/1/?file=71768#file71768line154>
> >
> >     necessary?

Technically no (same for the following ones). I made it explicit in those cases nevertheless to reduce risk of breakage when those methods are changed in the future (as continuing in these places would be a problem).


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105474/#review15513
-----------------------------------------------------------


On July 7, 2012, 2:55 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105474/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 2:55 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This addresses the problem that on cross-resource moves only the top-level collections ends up being written to the backend, but none of its content or sub-folders.
> 
> If such a move is received by the resource, it's now replayed recursively for all sub-folders and items.
> 
> This needs a recent Akonadi server, otherwise it wont have any effect.
> 
> It's already in master, please review for backporting to the 4.9 branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/CMakeLists.txt 2f0a11b 
>   akonadi/agentbase_p.h 6c72e85 
>   akonadi/monitor.h d43b401 
>   akonadi/monitor.cpp d2037b4 
>   akonadi/monitor_p.h 3a3253e 
>   akonadi/monitor_p.cpp e1aa4bc 
>   akonadi/recursivemover.cpp PRE-CREATION 
>   akonadi/recursivemover_p.h PRE-CREATION 
>   akonadi/resourcebase.h fcbc9fd 
>   akonadi/resourcebase.cpp 48f61f7 
>   akonadi/resourcescheduler.cpp 3ddaf7a 
>   akonadi/resourcescheduler_p.h 6db2fab 
> 
> Diff: http://git.reviewboard.kde.org/r/105474/diff/
> 
> 
> Testing
> -------
> 
> Tested with synchronous (maildir) and asynchronous (imap) move targets.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/