[Kde-pim] Review Request: Fix search dialog focus behavior
Allen Winter
winter at kde.org
Tue Jul 10 21:04:45 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105510/#review15639
-----------------------------------------------------------
Ship it!
Ship It!
- Allen Winter
On July 10, 2012, 6:58 p.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105510/
> -----------------------------------------------------------
>
> (Updated July 10, 2012, 6:58 p.m.)
>
>
> Review request for KDEPIM.
>
>
> Description
> -------
>
> Usability: Fix the korganizer search dialog focus behavior on start. (the line edit has focus now).
>
> I'm not sure why explicitely setting the tab order alone does not fix it, but using a delayed setFocus() call on the search line edit solves it for now.
>
> EDIT:
> The RR contains two commits (the first one basically cleans up the search dialog class a bit), the second one actually fixing the issue.
> Sadly, reviewboard does not display it properly, it seems.
>
>
> Diffs
> -----
>
> korganizer/searchdialog.h a7ea62004aa975361580c5d79ea3c5fe230ddb70
> korganizer/searchdialog.cpp b45f6c356624d1873388d4a86b92cee798016efc
> korganizer/searchdialog_base.ui 351d6d47906082486101204f47aeda07680ca87e
>
> Diff: http://git.reviewboard.kde.org/r/105510/diff/
>
>
> Testing
> -------
>
> Worksforme.
>
>
> Thanks,
>
> Kevin Funk
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list