[Kde-pim] Review Request: fix display of expanded attachment names in enterprise header style

Volker Krause vkrause at kde.org
Sun Jul 22 17:11:22 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105649/#review16208
-----------------------------------------------------------

Ship it!


Looks good to me, thanks!

- Volker Krause


On July 21, 2012, 11:08 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105649/
> -----------------------------------------------------------
> 
> (Updated July 21, 2012, 11:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> As described in the bug report, the expanded attachment names in the header area currently overlaps the sender/receiver names.
> 
> This patch fixes this by putting the attachment names into a new row in the header area so that the header nicely increases
> its height and does not overlap anything, in the same way as the fancy header style does it.
> 
> 
> This addresses bug 235459.
>     http://bugs.kde.org/show_bug.cgi?id=235459
> 
> 
> Diffs
> -----
> 
>   messageviewer/headerstyle.cpp 295799a 
> 
> Diff: http://git.reviewboard.kde.org/r/105649/diff/
> 
> 
> Testing
> -------
> 
> using different number of attachments; attachments in encapsulated messages
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list