[Kde-pim] Review Request: Fix for: kmail does never start migration

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105788/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

I have no kmail2rc and no kmail-migration config file, and when I run kmail
for the first time, it ask me if I want to migrate. So far so good.
But the next step after saying "Yes, migrate" I get the message that
kmail-migration failed and in the konsole output I see
"Migration of kmailrc has already run, not running it again";

The problem is:

kmail writes to kmail-migration BEFORE it starts kmail-migration tool,
but this tool now checks the config if it needs to run at all
(this check was included with 
https://projects.kde.org/projects/kde/kdepim-runtime/repository/revisions/60f8c01542f86bd04cafd68b91c2f609d73d4aa2
)
which obviously will never work ...

After creating the patch, I found the mentioned bug entry, which also includes nearly the same patch.
Whereby I would not include the second part of that bko patch as this is done by the migration tool itself.


This addresses bug 283563.
    http://bugs.kde.org/show_bug.cgi?id=283563


Diffs
-----

  kmail/kmkernel.cpp 376dc17 

Diff: http://git.reviewboard.kde.org/r/105788/diff/


Testing
-------

Starting kmail several times and pressing cancel, skip migration, migration with checks what happens.


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/