[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, part 1 from akonadi

Thu Jul 19 21:04:57 BST 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105617/#review16135
-----------------------------------------------------------

good work!
I found a couple of additional candidates while reviewing and I think a couple of changes that seem to be left-overs from a debugging session

akonadi/agentbase.h
<http://git.reviewboard.kde.org/r/105617/#comment12673>

    no, no space between function name and (
    just keep as it is

akonadi/agentbase.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12674>

    for the next round of cleanups:
    I think this should be an i18n call instead of QString::fromLatin1

akonadi/agenttypewidget.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12675>

    no, operator= is the function name
    operator=( option )

akonadi/attributefactory.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12676>

    Attribute *attr

akonadi/changemediator_p.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12677>

    space between comma and monitor

akonadi/collectioncreatejob.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12678>

    unwanted change?

akonadi/collectioncreatejob.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12679>

    same here?

akonadi/collectioncreatejob.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12680>

    same here?

akonadi/collectioncreatejob.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12681>

    Attribute *attr

akonadi/collectioncreatejob.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12682>

    unwanted change?

akonadi/collectioncreatejob.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12683>

    same here?

akonadi/collectioncreatejob.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12684>

    same here?

akonadi/collectionmodel_p.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12685>

    spaces in at() around row

akonadi/collectionstatisticsdelegate.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12686>

    ( option )

akonadi/collectionsync.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12687>

    LocalNode *localNode

akonadi/collectionsync.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12688>

    LocalNode *localParent

akonadi/collectionsync.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12689>

    RemoteNode *remoteNode

akonadi/collectionsync.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12690>

    RemoteNode *orphan

akonadi/contact/contactstreemodel.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12708>

    spaces in ()

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12709>

    QWidget *mainWidget

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12710>

    QVBoxLayout *topLayout

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12711>

    QLabel *label

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12712>

    connect( ... )

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12713>

    QLabel *newTabLabel

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12714>

    connect( ... )

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12715>

    QHBoxLayout *newTagLayout

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12716>

    connect( ... )

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12717>

    connect( ... )

akonadi/contact/editor/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12718>

    QListWidgetItem *item

akonadi/control.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12691>

    QWidget *widget

akonadi/entityorderproxymodel.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12693>

    {} around body

akonadi/entityorderproxymodel.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12694>

    spaces, {} around body

akonadi/favoritecollectionsmodel.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12695>

    {} around body

akonadi/favoritecollectionsmodel.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12696>

    { on wrong line

akonadi/favoritecollectionsmodel.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12697>

    {} around body 

akonadi/item.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12692>

    {} around body

akonadi/kmime/standardmailactionmanager.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12719>

    {} around body 

akonadi/kmime/standardmailactionmanager.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12720>

    same here

akonadi/kmime/standardmailactionmanager.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12721>

    same here

akonadi/kmime/standardmailactionmanager.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12722>

    and here

akonadi/objectnotificationmessage.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12698>

    spaces

akonadi/objectnotificationmessage.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12699>

    spaces

akonadi/objectnotificationmessage.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12700>

    spaces

akonadi/objectnotificationmessage.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12701>

    spaces

akonadi/pastehelper.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12703>

    {} around body 

akonadi/pastehelper.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12702>

    {} around body 

akonadi/servermanager.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12704>

    also add space between switch and (

akonadi/servermanager.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12705>

    see above

akonadi/specialcollections.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12706>

    unrelated change?

akonadi/specialcollections.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12707>

    unrelated changed end?

akonadi/tests/collectioncreator.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12723>

    {} around body 

akonadi/tests/linktest.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12724>

    {} around body 

akonadi/tests/testrunner/config.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12725>

    {} around body 

akonadi/tests/testrunner/main.cpp
<http://git.reviewboard.kde.org/r/105617/#comment12726>

    {} around body 

- Kevin Krammer

On July 19, 2012, 8:34 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105617/
> -----------------------------------------------------------
> 
> (Updated July 19, 2012, 8:34 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> As diskussed with Kevin, coding-style changes, same as at kdepim-runtime.
> As proposed by Kevin, some 800 bloks arounding { ... }
> 
> 
> Diffs
> -----
> 
>   akonadi/actionstatemanager.cpp fcee4c2 
>   akonadi/agentbase.h bac3e65 
>   akonadi/agentbase.cpp 940bf26 
>   akonadi/agentbase_p.h 0f90e85 
>   akonadi/agentfactory.h 9acd257 
>   akonadi/agentfactory.cpp d1aa9e6 
>   akonadi/agentfilterproxymodel.cpp 2e42ce8 
>   akonadi/agentinstance.h c1ed963 
>   akonadi/agentinstance.cpp 33b73ba 
>   akonadi/agentinstancecreatejob.cpp f69ff88 
>   akonadi/agentinstancemodel.h 4f7e950 
>   akonadi/agentinstancemodel.cpp 4fa3541 
>   akonadi/agentinstancewidget.cpp b22c98d 
>   akonadi/agentmanager.cpp 632a0ae 
>   akonadi/agenttype.cpp 0d235be 
>   akonadi/agenttypedialog.cpp c958f4f 
>   akonadi/agenttypemodel.h 41f1dff 
>   akonadi/agenttypemodel.cpp deac3b3 
>   akonadi/agenttypewidget.cpp 8da6877 
>   akonadi/asyncselectionhandler.cpp fe40521 
>   akonadi/attributefactory.cpp 4147a86 
>   akonadi/cachepolicypage.h 859b2f4 
>   akonadi/cachepolicypage.cpp 0468f15 
>   akonadi/calendar/standardcalendaractionmanager.cpp 4ee8a3d 
>   akonadi/changemediator_p.cpp 9f17707 
>   akonadi/changenotificationdependenciesfactory.cpp 90e0848 
>   akonadi/changerecorder.cpp 8280c59 
>   akonadi/changerecorder_p.h d6c6519 
>   akonadi/collection.h bbc561e 
>   akonadi/collection.cpp d860cbe 
>   akonadi/collectioncombobox.cpp 425a62d 
>   akonadi/collectioncreatejob.cpp 2fefe7e 
>   akonadi/collectiondeletejob.cpp cb82065 
>   akonadi/collectiondialog.h d7e7079 
>   akonadi/collectiondialog_desktop.cpp 1934689 
>   akonadi/collectiondialog_mobile.cpp abd583e 
>   akonadi/collectionfetchjob.h a46533e 
>   akonadi/collectionfetchjob.cpp f6f4bc6 
>   akonadi/collectionfetchscope.cpp 41bb5d8 
>   akonadi/collectionfilterproxymodel.cpp 60f07c1 
>   akonadi/collectiongeneralpropertiespage.cpp fa4f91f 
>   akonadi/collectionmodel.cpp 4b5e63c 
>   akonadi/collectionmodel_p.h dc7bf39 
>   akonadi/collectionmodel_p.cpp f23302b 
>   akonadi/collectionmodifyjob.cpp 7774f69 
>   akonadi/collectionpathresolver.cpp 865b41a 
>   akonadi/collectionpropertiesdialog.cpp d87b567 
>   akonadi/collectionquotaattribute.h a6ee583 
>   akonadi/collectionquotaattribute.cpp 00dcc8a 
>   akonadi/collectionrequester.cpp 271540e 
>   akonadi/collectionrightsattribute.cpp 66e4078 
>   akonadi/collectionstatisticsdelegate.cpp e33e6cf 
>   akonadi/collectionstatisticsmodel.cpp be97874 
>   akonadi/collectionsync.cpp d5e4714 
>   akonadi/collectionutils_p.h 54a2057 
>   akonadi/collectionview.cpp 5bf0dd7 
>   akonadi/conflicthandling/abstractdifferencesreporter.h 1339433 
>   akonadi/conflicthandling/conflicthandler_p.h bbc6769 
>   akonadi/conflicthandling/conflictresolvedialog.cpp b6ac333 
>   akonadi/contact/abstractcontactformatter.h d170dae 
>   akonadi/contact/abstractcontactgroupformatter.h 24b4665 
>   akonadi/contact/actions/dialphonenumberaction.cpp 7437f2f 
>   akonadi/contact/actions/qskypedialer.cpp a8a8c9e 
>   akonadi/contact/actions/qwincedialer.cpp 7d12bc1 
>   akonadi/contact/actions/sendsmsaction.h 710159d 
>   akonadi/contact/actions/sendsmsaction.cpp d159271 
>   akonadi/contact/actions/showaddressaction.cpp 22f2f47 
>   akonadi/contact/actions/smsdialog.h b93ca08 
>   akonadi/contact/actions/smsdialog.cpp 4761a68 
>   akonadi/contact/collectionfiltermodel.cpp 1e29b1b 
>   akonadi/contact/contactcompletionmodel.cpp 5b9a1ee 
>   akonadi/contact/contactcompletionmodel_p.h e836a0d 
>   akonadi/contact/contactdefaultactions.cpp 7957614 
>   akonadi/contact/contacteditor.h 76824b2 
>   akonadi/contact/contacteditor.cpp 2676092 
>   akonadi/contact/contacteditordialog.h 91adca8 
>   akonadi/contact/contacteditordialog.cpp 9e9040f 
>   akonadi/contact/contactgroupeditor.cpp 47ca91e 
>   akonadi/contact/contactgroupeditordelegate.cpp 5890a97 
>   akonadi/contact/contactgroupeditordialog.h f9a9837 
>   akonadi/contact/contactgroupeditordialog.cpp ada28ba 
>   akonadi/contact/contactgroupexpandjob.cpp 75b2ade 
>   akonadi/contact/contactgrouplineedit.cpp 5c00905 
>   akonadi/contact/contactgroupmodel.cpp d584ca3 
>   akonadi/contact/contactgroupmodel_p.h 09c5b86 
>   akonadi/contact/contactgroupsearchjob.h 0ec8cbe 
>   akonadi/contact/contactgroupsearchjob.cpp b845b61 
>   akonadi/contact/contactgroupviewer.cpp 89ef24d 
>   akonadi/contact/contactmetadata.cpp 25b790b 
>   akonadi/contact/contactsearchjob.h 3357135 
>   akonadi/contact/contactsearchjob.cpp a1a5852 
>   akonadi/contact/contactsfilterproxymodel.h 89101e7 
>   akonadi/contact/contactsfilterproxymodel.cpp 04521a8 
>   akonadi/contact/contactstreemodel.h 0823a04 
>   akonadi/contact/contactstreemodel.cpp f59dfc0 
>   akonadi/contact/contactviewer.cpp 9f850bd 
>   akonadi/contact/customfields.cpp 54f4c95 
>   akonadi/contact/customfields_p.h cd6ce78 
>   akonadi/contact/editor/addresseditwidget.cpp 046fa7f 
>   akonadi/contact/editor/categorieseditwidget.cpp 4f237d9 
>   akonadi/contact/editor/contacteditorwidget.cpp 2cad304 
>   akonadi/contact/editor/customfieldeditordialog.cpp cbd06f6 
>   akonadi/contact/editor/customfieldseditwidget.cpp 8a1a712 
>   akonadi/contact/editor/customfieldsmodel.h ad42763 
>   akonadi/contact/editor/customfieldsmodel.cpp 0f20e3e 
>   akonadi/contact/editor/dateeditwidget.cpp 502cfec 
>   akonadi/contact/editor/displaynameeditwidget.h 567b2ae 
>   akonadi/contact/editor/displaynameeditwidget.cpp 7c6fa66 
>   akonadi/contact/editor/emaileditwidget.cpp d6f07e9 
>   akonadi/contact/editor/freebusyeditwidget.cpp 443ac53 
>   akonadi/contact/editor/geoeditwidget.cpp d26832e 
>   akonadi/contact/editor/im/immodel.h 546675d 
>   akonadi/contact/editor/im/immodel.cpp 1e96d83 
>   akonadi/contact/editor/im/improtocols.cpp 6cda468 
>   akonadi/contact/editor/imagewidget.cpp ebf6b54 
>   akonadi/contact/editor/imeditwidget.cpp 340d3d0 
>   akonadi/contact/editor/kedittagsdialog.cpp 4e82efe 
>   akonadi/contact/editor/phoneeditwidget.cpp 449014a 
>   akonadi/contact/editor/secrecyeditwidget.cpp ef46639 
>   akonadi/contact/editor/soundeditwidget.cpp f15d825 
>   akonadi/contact/editor/tagwidget.cpp 4fd3f11 
>   akonadi/contact/emailaddressselection.cpp 09dcfb8 
>   akonadi/contact/emailaddressselectiondialog.cpp 9546788 
>   akonadi/contact/emailaddressselectionproxymodel.cpp d5e90e6 
>   akonadi/contact/emailaddressselectionproxymodel_p.h ebc58bf 
>   akonadi/contact/emailaddressselectionwidget.cpp 5ec2783 
>   akonadi/contact/kcm/kcmakonadicontactactions.cpp 2b5fa64 
>   akonadi/contact/leafextensionproxymodel.cpp c46ab27 
>   akonadi/contact/recentcontactscollectionrequestjob.cpp c55b951 
>   akonadi/contact/standardcontactactionmanager.cpp 63dd66d 
>   akonadi/contact/standardcontactformatter.cpp db569ea 
>   akonadi/contact/standardcontactgroupformatter.cpp 76503dc 
>   akonadi/contact/tests/emailaddressselectiondialogtest.cpp fd8671c 
>   akonadi/contact/tests/emailaddressselectionwidgettest.cpp bc46c7a 
>   akonadi/contact/textbrowser_p.h 4b8cea7 
>   akonadi/contact/waitingoverlay.cpp 9718bdc 
>   akonadi/control.cpp 500db20 
>   akonadi/dbusconnectionpool.cpp 5a50650 
>   akonadi/dragdropmanager.cpp 6127dfe 
>   akonadi/dragdropmanager_p.h 57fb735 
>   akonadi/entitylistview.h 0235008 
>   akonadi/entitylistview.cpp ccb53b8 
>   akonadi/entityorderproxymodel.cpp da132bf 
>   akonadi/entitytreeview.h fcd03e8 
>   akonadi/entitytreeview.cpp 9cd750b 
>   akonadi/favoritecollectionsmodel.cpp 60391ee 
>   akonadi/item.cpp 7d90d0f 
>   akonadi/kjobprivatebase_p.h 549c30c 
>   akonadi/kmime/addressattribute.h 796fbb3 
>   akonadi/kmime/commandbase.cpp 57a398a 
>   akonadi/kmime/emptytrashcommand.cpp 4768c1e 
>   akonadi/kmime/emptytrashcommand_p.h e1f8041 
>   akonadi/kmime/markascommand_p.h d7b497f 
>   akonadi/kmime/standardmailactionmanager.cpp 318178a 
>   akonadi/mimetypechecker.cpp 8ad7530 
>   akonadi/objectnotificationmessage.cpp 0dd4a53 
>   akonadi/pastehelper.cpp 99c8c44 
>   akonadi/protocolhelper.cpp 187c74f 
>   akonadi/protocolhelper_p.h bb2641a 
>   akonadi/recentcollectionaction_p.h 9f5d6c8 
>   akonadi/recursivecollectionfilterproxymodel.h 3058d4c 
>   akonadi/renamefavoritedialog.h 0c0a210 
>   akonadi/servermanager.cpp 9765966 
>   akonadi/sharedvaluepool_p.h 386acd6 
>   akonadi/specialcollections.cpp cc6960c 
>   akonadi/specialcollectionshelperjobs_p.h 858e091 
>   akonadi/standardactionmanager.h aa403ec 
>   akonadi/tests/actionstatemanagertest.cpp 74f5a83 
>   akonadi/tests/benchmarker/test.h e7d1055 
>   akonadi/tests/collectioncreator.cpp 9132532 
>   akonadi/tests/linktest.cpp 5688557 
>   akonadi/tests/testenvironmenttest.cpp dad40fe 
>   akonadi/tests/testrunner/config.cpp 99891ba 
>   akonadi/tests/testrunner/main.cpp c0bf7b0 
> 
> Diff: http://git.reviewboard.kde.org/r/105617/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/