[Kde-pim] Review Request: enhance date-time parser to allow formats which were possible in KDE3

Allen Winter winter at kde.org
Sat Jul 14 01:12:58 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105560/#review15826
-----------------------------------------------------------

Ship it!


Looks good.  Very big thanks for adding the unit tests.
Please put this in master, 4.9 and 4.8 branches

- Allen Winter


On July 13, 2012, 7:38 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105560/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 7:38 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> The date-time parser in KDE3 was once enhanced by me to also allow non RFC conforming formats.
> These possibilities got lost in the transition to KDE4.
> This patch implements some more format possibilities
> 
> 
> This addresses bugs 54098 and 260761.
>     http://bugs.kde.org/show_bug.cgi?id=54098
>     http://bugs.kde.org/show_bug.cgi?id=260761
> 
> 
> Diffs
> -----
> 
>   kmime/kmime_header_parsing.cpp b8feb2f 
>   kmime/tests/auto/headertest.cpp 2c1ff07 
> 
> Diff: http://git.reviewboard.kde.org/r/105560/diff/
> 
> 
> Testing
> -------
> 
> added unit tests for the other formats.
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list