[Kde-pim] Review Request: some more spaces, some less spaces, kdepim-runtime/resources, not kalarm

Guy Maurel guy-kde at maurel.de
Sat Jul 14 19:14:34 BST 2012



> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/imap/changeitemtask.cpp, line 289
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72111#file72111line289>
> >
> >     space around +

I haven't test that in my script.
To find such a "wrong" coding-style, and not to get too many false alarms, one need a compiler.
I am working on a "plugin" to add to the g++ compiler.
This could solve much more situations and give the developpers a "better quality" of the messages.
can you wait a little bit, I need some more time to do this.
Thanks for every new ideas for the plugin.


> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/imap/imapresource.cpp, line 476
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72113#file72113line476>
> >
> >     theoretically {} even for one line bodies

same as above.
There are many, many sources, blocks, lines to modify.


> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/imap/imapresource.cpp, line 478
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72113#file72113line478>
> >
> >     ResourceTask *task

same


> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/imap/resourcetask.cpp, line 374
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72116#file72116line374>
> >
> >     I think this should actually be a translatable string, i.e. in i18n()

Right!
This is the next rule for my plugin.


> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/maildir/libmaildir/maildir.cpp, line 90
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72151#file72151line90>
> >
> >     no, == is part of the operator name
> >     but Private &rhs

Thanks


> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/maildir/libmaildir/maildir.cpp, line 209
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72151#file72151line209>
> >
> >     spaces in ()

we wrote about "not doing any change in a function declaration", some weeks ago.
There are many, many sources with this coding-style.
May I link you to my plugin, later again?


> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/maildir/libmaildir/maildir.cpp, line 94
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72151#file72151line94>
> >
> >     QString &error

we wrote about "not making any change on function declaration", some weeks ago.
That could be also included in the "plugin"


> On July 13, 2012, 7:26 p.m., Kevin Krammer wrote:
> > resources/shared/singlefileresource.h, line 124
> > <http://git.reviewboard.kde.org/r/105523/diff/1/?file=72205#file72205line124>
> >
> >     move to else?

yes and no!
This is many times to be found around the sources.
There is a comment, and it is difficult to find the right place for it.
The next problem is, if we have a pre-compiler switch, such as:
..
}
# if not defined abc
  else {
    ..
# endif


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105523/#review15817
-----------------------------------------------------------


On July 14, 2012, 6:14 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105523/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 6:14 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Description
> -------
> 
> the next step to accord to the coding-style
> 
> 
> Diffs
> -----
> 
>   accountwizard/personaldatapage.cpp bcb14c3 
>   accountwizard/providerpage.cpp 47aeaab 
>   agents/maildispatcher/sendjob.cpp 12120e6 
>   agents/nepomukfeeder/nepomukfeederagent.h 2b2c2ea 
>   agents/nepomukfeeder/nepomukfeederagent.cpp 0b9bd8c 
>   agents/nepomukfeeder/plugin/nepomukfeederplugin.h eb17d7a 
>   agents/nepomukfeeder/test/akonadinepomukfeeder_indexer.cpp 7a7de03 
>   resources/contacts/contactsresource.cpp f0bb665 
>   resources/dav/common/davitem.h 77b5d42 
>   resources/dav/common/davprincipalhomesetsfetchjob.cpp e167e55 
>   resources/dav/common/davprincipalsearchjob.cpp f2acece 
>   resources/dav/resource/davgroupwareresource.cpp fbe58d4 
>   resources/dav/resource/setupwizard.cpp 44dc752 
>   resources/google/calendar/calendarresource.cpp 38a26aa 
>   resources/google/calendar/resource_tasks.cpp 1cf83c1 
>   resources/google/contacts/contactsresource.cpp 6f292ff 
>   resources/ical/shared/icalresourcebase.cpp 906e6d3 
>   resources/imap/addcollectiontask.cpp cea288a 
>   resources/imap/additemtask.cpp da965a1 
>   resources/imap/changecollectiontask.cpp 875bf8b 
>   resources/imap/changeitemtask.cpp 1a5e969 
>   resources/imap/imapidlemanager.cpp 1f1bcae 
>   resources/imap/imapresource.cpp 4c2cb04 
>   resources/imap/resourcestate.cpp 7aa42d8 
>   resources/imap/resourcetask.h 3893a5d 
>   resources/imap/resourcetask.cpp c97b413 
>   resources/imap/retrievecollectionmetadatatask.cpp 3c454e3 
>   resources/imap/retrieveitemstask.cpp 15a966b 
>   resources/imap/retrieveitemtask.cpp a7d2460 
>   resources/imap/sessionpool.cpp d3ea149 
>   resources/imap/sessionuiproxy.h d60e7b7 
>   resources/imap/settings.cpp b38c820 
>   resources/imap/settingspasswordrequester.cpp 488e7f1 
>   resources/imap/setupserver.cpp c6d6d7c 
>   resources/imap/subscriptiondialog.cpp d29bc54 
>   resources/imap/tests/dummyresourcestate.cpp 518bf8a 
>   resources/imap/tests/imaptestbase.cpp 3aec6e9 
>   resources/imap/tests/testaddcollectiontask.cpp c8816d3 
>   resources/imap/tests/testadditemtask.cpp 53cb0e5 
>   resources/imap/tests/testchangecollectiontask.cpp 8dc4230 
>   resources/imap/tests/testchangeitemtask.cpp 20b6a6c 
>   resources/imap/tests/testexpungecollectiontask.cpp 424c08f 
>   resources/imap/tests/testmovecollectiontask.cpp 894ba71 
>   resources/imap/tests/testmoveitemtask.cpp 3bf67b2 
>   resources/imap/tests/testremovecollectiontask.cpp ba1780b 
>   resources/imap/tests/testremoveitemtask.cpp 0e61135 
>   resources/imap/tests/testresourcetask.cpp 7600bb9 
>   resources/imap/tests/testretrievecollectionmetadatatask.cpp 46f97f4 
>   resources/imap/tests/testretrievecollectionstask.cpp c9b41bb 
>   resources/imap/tests/testretrieveitemstask.cpp b542423 
>   resources/imap/tests/testretrieveitemtask.cpp d308075 
>   resources/imap/tests/testsessionpool.cpp 43e2fc4 
>   resources/kabc/kresourceassistant.cpp cf18a71 
>   resources/kcal/kcalresource.cpp 704aa2b 
>   resources/kolabproxy/incidencehandler.cpp fa8f0c2 
>   resources/kolabproxy/kolabhandler.cpp 322260c 
>   resources/kolabproxy/kolabproxyresource.cpp de40798 
>   resources/kolabproxy/setupdefaultfoldersjob.cpp 1da170a 
>   resources/kolabproxy/tests/kolabconvertertest.cpp c3db5ac 
>   resources/kolabproxy/upgradejob.cpp 8e2abc3 
>   resources/maildir/libmaildir/maildir.cpp b6bb579 
>   resources/maildir/libmaildir/maildir_export.h 9246b53 
>   resources/maildir/libmaildir/tests/testmaildir.cpp bda8745 
>   resources/maildir/maildirresource.cpp 24c287c 
>   resources/maildir/retrieveitemsjob.cpp 86bec65 
>   resources/mailtransport_dummy/configdialog.cpp f51eb66 
>   resources/mailtransport_dummy/mtdummyresource.cpp 192874a 
>   resources/mbox/deleteditemsattribute.cpp f1bebd4 
>   resources/mbox/lockmethodpage.cpp 1d30510 
>   resources/mbox/mboxresource.cpp 7a68aa0 
>   resources/microblog/configdialog.cpp d44d5b1 
>   resources/microblog/microblog.cpp 7c68458 
>   resources/mixedmaildir/compactchangehelper.cpp 0ec95f9 
>   resources/mixedmaildir/configdialog.cpp 10a6d68 
>   resources/mixedmaildir/kmindexreader/kmindexreader.cpp 05277d2 
>   resources/mixedmaildir/mixedmaildirresource.h 0e95456 
>   resources/mixedmaildir/mixedmaildirresource.cpp 32641e1 
>   resources/mixedmaildir/mixedmaildirstore.cpp 4dadfd9 
>   resources/mixedmaildir/retrieveitemsjob.h ce9e53b 
>   resources/mixedmaildir/retrieveitemsjob.cpp 6aa0159 
>   resources/mixedmaildir/tests/collectionfetchtest.cpp ce05de8 
>   resources/mixedmaildir/tests/collectionmodifytest.cpp 31c0c3f 
>   resources/mixedmaildir/tests/collectionmovetest.cpp b2e7358 
>   resources/mixedmaildir/tests/itemcreatetest.cpp d5ebac2 
>   resources/mixedmaildir/tests/itemdeletetest.cpp 94f5026 
>   resources/mixedmaildir/tests/itemfetchtest.cpp 13ac8fa 
>   resources/mixedmaildir/tests/itemmodifytest.cpp 4653a35 
>   resources/mixedmaildir/tests/itemmovetest.cpp 687d474 
>   resources/mixedmaildir/tests/storecompacttest.cpp a454f5d 
>   resources/mixedmaildir/tests/testdatatest.cpp 04a770d 
>   resources/mixedmaildir/tests/testdatautil.cpp 58f6f18 
>   resources/nepomuktag/nepomuktagresource.cpp 435ddde 
>   resources/nntp/nntpresource.cpp 551baf5 
>   resources/openxchange/openxchangeresource.cpp e59292a 
>   resources/openxchange/oxa/folder.h 2a82623 
>   resources/openxchange/oxa/foldersrequestjob.h b176014 
>   resources/openxchange/oxa/folderutils.cpp 6167f6f 
>   resources/openxchange/oxa/incidenceutils.cpp 1f8c5a9 
>   resources/openxchange/oxa/object.h f93ce72 
>   resources/openxchange/oxa/objectsrequestjob.h 05ad10a 
>   resources/openxchange/oxa/oxutils.cpp 95571af 
>   resources/openxchange/oxa/updateusersjob.cpp 04dd8e6 
>   resources/openxchange/oxa/user.cpp df004de 
>   resources/pop3/accountdialog.cpp 691fa94 
>   resources/pop3/jobs.cpp d500521 
>   resources/pop3/pop3resource.cpp da010c0 
>   resources/pop3/tests/fakeserver/fakeserver.cpp adba125 
>   resources/pop3/tests/pop3test.cpp 5c82923 
>   resources/shared/filestore/abstractlocalstore.cpp 9d94f91 
>   resources/shared/filestore/collectionfetchjob.h f6918c6 
>   resources/shared/filestore/entitycompactchangeattribute.cpp 3484b49 
>   resources/shared/filestore/job.h b5fb9f9 
>   resources/shared/filestore/sessionimpls.cpp e5f651c 
>   resources/shared/imapquotaattribute.cpp 1747c03 
>   resources/shared/singlefileresource.h 3f0c56f 
>   resources/shared/singlefileresourcebase.cpp a2ecfa6 
>   resources/shared/singlefileresourceconfigdialogbase.cpp 3490d07 
>   resources/vcard/vcardresource.cpp fb4565d 
>   resources/vcarddir/settingsdialog.cpp 8bc3680 
> 
> Diff: http://git.reviewboard.kde.org/r/105523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list