[Kde-pim] Review Request: Fix cross-resource collection moving

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105474/#review15513
-----------------------------------------------------------



akonadi/agentbase_p.h
<http://git.reviewboard.kde.org/r/105474/#comment12131>

    not binary compatible
    http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_access_rights



akonadi/monitor.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12107>

    whitespace
    ( bool enabled )



akonadi/monitor_p.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12108>

    whitespace in second parentheses



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12109>

    whitespace
    ( AgentBasePrivate *parent )
    KCompositeJob( parent )
    



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12110>

    CollectionFetchJob *job



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12111>

    Collection &collection
    Collection &oarentCollection



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12112>

    ( KJob *job )



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12113>

    whitespace in parentheses



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12114>

    position of *



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12115>

    kids as in children or k IDs?



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12116>

    whitespace in parentheses



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12117>

    ..Job *fetchJob



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12118>

    whitespace in parentheses, position of *



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12119>

    ...Job *fetchJob



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12120>

    ...Job *job



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12121>

    necessary?



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12122>

    necessary?



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12123>

    necessary?



akonadi/recursivemover.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12124>

    ...Job *job



akonadi/recursivemover_p.h
<http://git.reviewboard.kde.org/r/105474/#comment12125>

    whitespace in parentheses, position of *



akonadi/recursivemover_p.h
<http://git.reviewboard.kde.org/r/105474/#comment12126>

    maybe Q_SLOTS for consistency with the majority of the other headers?



akonadi/recursivemover_p.h
<http://git.reviewboard.kde.org/r/105474/#comment12127>

    whitespace in parentheses, position of *



akonadi/recursivemover_p.h
<http://git.reviewboard.kde.org/r/105474/#comment12128>

    ...Private *m_agentBase



akonadi/resourcebase.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12129>

    RecursiveMover *mover



akonadi/resourcebase.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12130>

    KJob *job



akonadi/resourcebase.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12132>

    whitespace in parentheses, position of *



akonadi/resourcebase.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12133>

    guess :)



akonadi/resourcescheduler.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12134>

    RecursiveMover *mover



akonadi/resourcescheduler.cpp
<http://git.reviewboard.kde.org/r/105474/#comment12135>

    TaskList &queue



akonadi/resourcescheduler_p.h
<http://git.reviewboard.kde.org/r/105474/#comment12136>

    position of *


- Kevin Krammer


On July 7, 2012, 2:55 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105474/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 2:55 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This addresses the problem that on cross-resource moves only the top-level collections ends up being written to the backend, but none of its content or sub-folders.
> 
> If such a move is received by the resource, it's now replayed recursively for all sub-folders and items.
> 
> This needs a recent Akonadi server, otherwise it wont have any effect.
> 
> It's already in master, please review for backporting to the 4.9 branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/CMakeLists.txt 2f0a11b 
>   akonadi/agentbase_p.h 6c72e85 
>   akonadi/monitor.h d43b401 
>   akonadi/monitor.cpp d2037b4 
>   akonadi/monitor_p.h 3a3253e 
>   akonadi/monitor_p.cpp e1aa4bc 
>   akonadi/recursivemover.cpp PRE-CREATION 
>   akonadi/recursivemover_p.h PRE-CREATION 
>   akonadi/resourcebase.h fcbc9fd 
>   akonadi/resourcebase.cpp 48f61f7 
>   akonadi/resourcescheduler.cpp 3ddaf7a 
>   akonadi/resourcescheduler_p.h 6db2fab 
> 
> Diff: http://git.reviewboard.kde.org/r/105474/diff/
> 
> 
> Testing
> -------
> 
> Tested with synchronous (maildir) and asynchronous (imap) move targets.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/