[Kde-pim] Review Request: Remove close button on the Article tab in Akregator

Allen Winter winter at kde.org
Tue Jul 10 21:13:31 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105504/#review15640
-----------------------------------------------------------


I tested this patch and I don't like the new behavior.

For me, the first close button on the first tab disappears immediately after I open another tab, for example with I click on the "The complete story" link.

As long as more than 1 tab is open, I think the close button should be available on all tabs.

- Allen Winter


On July 10, 2012, 1:58 p.m., Phương Lê Hoàng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105504/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 1:58 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Completely remove the close button on the Article tab in Akregator.
> Related bug: https://bugs.kde.org/show_bug.cgi?id=173067 (This bug is marked as solved).
> 
> 
> Diffs
> -----
> 
>   akregator/src/tabwidget.cpp 82aa5bb 
> 
> Diff: http://git.reviewboard.kde.org/r/105504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Phương Lê Hoàng
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list