[Kde-pim] Review Request: Filter for priority in the Todo view of Korganizer

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105760/#review16641
-----------------------------------------------------------

Ship it!


I committed this patch with some changes, but not many.

A few nits:
1. the patch was made against 4.8 and not master. please start using master for features
2. you didn't follow coding style in a couple places
3. I added tooltips and whatsthis, but that wasn't your fault. I just noticed they were missing in a lot of places on the todo view.  more are still missing but eventually add them.
4. while testing I noticed some other nits that I fixed (again not part of your patch but just fyi)

Thanks so much for your work.  Please keep those patches coming!

- Allen Winter


On July 28, 2012, 12:43 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105760/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 12:43 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patch adds a Filter for priority (like categories) in the Todo view of Korganizer, as listed in https://bugs.kde.org/show_bug.cgi?id=214879
> Makes it easy to find tasks, by filtering them on the basis of priority.
> 
> 
> Diffs
> -----
> 
>   korganizer/views/todoview/kotodoview.cpp bcb49b4 
>   korganizer/views/todoview/kotodoviewquicksearch.h 9b63814 
>   korganizer/views/todoview/kotodoviewquicksearch.cpp d804993 
>   korganizer/views/todoview/kotodoviewsortfilterproxymodel.h 517667c 
>   korganizer/views/todoview/kotodoviewsortfilterproxymodel.cpp 6c026fe 
> 
> Diff: http://git.reviewboard.kde.org/r/105760/diff/
> 
> 
> Testing
> -------
> 
> I have tested it a bit and as long as I have tested, it works fine.
> 
> 
> Screenshots
> -----------
> 
> Priority filter on the right hand side
>   http://git.reviewboard.kde.org/r/105760/s/647/
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/