[Kde-pim] Review Request: Add a list of server capabilities
Ingo Klöcker
kloecker at kde.org
Wed Jan 4 22:17:54 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103627/#review9555
-----------------------------------------------------------
First of all, I think it's a good idea to make this information available somewhere.
But I'm not sure whether adding yet another tab is a good solution. Maybe it could be hidden behind a button on the Advanced tab. This button could open a separate dialog showing the capabilities (and later probably other information useful for diagnostics). *shrug*
Concerning the implementation I think using a QTextBrowser (or some other text widget) instead of a QListWidget would be better because the information is very useful for bug reports and thus it should be easy to copy.
- Ingo Klöcker
On Jan. 4, 2012, 6:03 p.m., Torgny Nyblom wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103627/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2012, 6:03 p.m.)
>
>
> Review request for KDEPIM.
>
>
> Description
> -------
>
> Adds a new tab to the IMAP settings dialog that lists the servers capabilities, also adds a helper function to extract that information.
>
>
> Diffs
> -----
>
> resources/imap/imapresource.h 48a7e91
> resources/imap/imapresource.cpp 70cf52f
> resources/imap/setupserver.cpp 68cbedf
> resources/imap/setupserverview_desktop.ui 4e0667c
>
> Diff: http://git.reviewboard.kde.org/r/103627/diff/diff
>
>
> Testing
> -------
>
> Compiles and seems to work.
>
>
> Screenshots
> -----------
>
> server info tab
> http://git.reviewboard.kde.org/r/103627/s/404/
>
>
> Thanks,
>
> Torgny Nyblom
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list