[Kde-pim] Review Request: KolabResource: The second time you call a retrieveItems() you get conflict dialogs

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103759/#review10167
-----------------------------------------------------------


Sounds sensible to me.

- Volker Krause


On Jan. 27, 2012, 9:46 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103759/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2012, 9:46 p.m.)
> 
> 
> Review request for KDEPIM, Volker Krause, Andras Mantia, Till Adam, and Kevin Krammer.
> 
> 
> Description
> -------
> 
> The second time you call a KolabResource::retrieveItems() you get conflict dialogs for every incidence, or, if the collection is read-only, nothing will happen, and no events will be emitted in itemsRetrieved().
> 
> This happens because the conflict handler has an internal structure, m_uidMap with all incidences. I think it should be cleared when doing retrieveItems().
> 
> 
> Diffs
> -----
> 
>   resources/kolabproxy/incidencehandler.h 98b97b9 
>   resources/kolabproxy/incidencehandler.cpp 0e17863 
>   resources/kolabproxy/kolabhandler.h ba63198 
>   resources/kolabproxy/kolabproxyresource.cpp 0ddf153 
> 
> Diff: http://git.reviewboard.kde.org/r/103759/diff/diff
> 
> 
> Testing
> -------
> 
> KOrganizer now shows all events, after you do "Sync Collection"
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/