[Kde-pim] Review Request: vCard export: option to export KAddressBook's display name as full name

[Jonathan Marten]

> On Jan. 23, 2012, 3:05 p.m., Commit Hook wrote:
> > This review has been submitted with commit 1b1290b3388810a6a8ea8e582aada3339fe8bd06 by Jonathan Marten to branch master.

With indentation corrected.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103760/#review10021
-----------------------------------------------------------


On Jan. 22, 2012, 4:02 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103760/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2012, 4:02 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The current vCard export generates name fields correctly according to RFC2426: N is the full name of the contact split up into components, while FN is the formatted name for display.  Unfortunately both GMail's contacts importer and Android appear to not handle these fields correctly; they both completely ignore the FN and show the N (with its components reassembled in the appropriate order) as the contact's name.  This means that the display name entered in KAddressBook is ignored.
> 
> This patch provides an option to output the display name, split up into first/last/others, as the contact's full name (N field).  When reassembled, this shows the display name as was set by the user in KAddressBook.
> 
> There is an additional check box in the "Select Fields" dialogue to choose whether this is required, see attached screen shot.  The default is false, in which case the export format is the same as before.
> 
> 
> Diffs
> -----
> 
>   kaddressbook/xxport/vcard/vcard_xxport.cpp 9cf905a 
> 
> Diff: http://git.reviewboard.kde.org/r/103760/diff/diff
> 
> 
> Testing
> -------
> 
> Built KAddressBook with these changes, checked vCard export and import into GMail and Android.  With the option selected, the display name as set by the user is correctly transferred and shown.  With the option not selected, the export operation is the same as before.
> 
> 
> Screenshots
> -----------
> 
> Dialogue with additional option
>   http://git.reviewboard.kde.org/r/103760/s/419/
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/