[Kde-pim] Review Request: vCard export: export birthday field as date only

[Jonathan Marten]

> On Jan. 30, 2012, 3:24 p.m., Commit Hook wrote:
> > This review has been submitted with commit 84878698a188f1f0729c3fd5379fcd79b46ae7e8 by Jonathan Marten to branch master.

Pushed the 1-line fix - given the explicit 2nd argument to the constructor this is obviously what the code is intending to do, it's just a quirk of Qt that it doesn't do what was intended.

Anniversaries are indeed not handled the same - they are stored as a string throughout, and explicitly converted with QDate::toString(Qt::ISODate).


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103776/#review10229
-----------------------------------------------------------


On Jan. 23, 2012, 8:27 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103776/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2012, 8:27 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The referenced bugs refer to the BDAY field in an exported vCard including a time field of midnight, even though the user will not have entered this in KAddressBook and there is no GUI to do so:
> 
> BDAY:1978-07-20T00:00:00Z
> 
> This is valid according to RFC2426, but unfortunately some receiving applications - notably GMail and Android - do not recognise the birthday field in this format and ignore it.  If the time part is removed:
> 
> BDAY:1978-07-20
> 
> then the birthday date is recognised.
> 
> This patch implements that, only for vCard export from KAddressBook.  It does not modify or change the behaviour of the KABC library, so not affecting any other applications that may use this format with a valid time (and kdelibs is frozen now anyway).
> 
> 
> This addresses bugs 118289 and 282169.
>     http://bugs.kde.org/show_bug.cgi?id=118289
>     http://bugs.kde.org/show_bug.cgi?id=282169
> 
> 
> Diffs
> -----
> 
>   kaddressbook/xxport/vcard/vcard_xxport.cpp bb4211b 
> 
> Diff: http://git.reviewboard.kde.org/r/103776/diff/diff
> 
> 
> Testing
> -------
> 
> Build kdepim with these changes, checked vCard export by visual inspection of the output and by import into GMail Contacts.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/