[Kde-pim] Review Request: More settings are stored in printing of contacts.

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103696/#review9849
-----------------------------------------------------------


instead of saving an index for the printing style, maybe you could save a printing style name?  that way, if the index order ever changes (for example if we add a printing style) things don't get messed-up?

but in general I like this and will definitely want to commit something like it.


kaddressbook/kaddressbook.kcfg
<http://git.reviewboard.kde.org/r/103696/#comment8157>

    huh?  that's not a good label or tooltip or whatsthis for PrintingStyle


- Allen Winter


On Jan. 14, 2012, 2:41 p.m., Mario Scheel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103696/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2012, 2:41 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The last used filename, sorting order and printing style are now stored.
> 
> 
> Diffs
> -----
> 
>   kaddressbook/kaddressbook.kcfg f173f63a62028b4ce2e19b5188fd90c68a515359 
>   kaddressbook/mainwidget.cpp 0fe5ce41583cae2ad2acf4ecc1f383675f5a83e0 
>   kaddressbook/printing/printingwizard.h ab39394d6006173f14ac4a477ccc70f88865440e 
>   kaddressbook/printing/printingwizard.cpp 6df4f65cc00dc723f534ba875ea88cae52f7e95f 
>   kaddressbook/printing/stylepage.h a6f75bdd20a2d8829455ce99ace1be73330a36f2 
>   kaddressbook/printing/stylepage.cpp 6685b9f9740c233741d88f1ad4461885b3ae1c59 
> 
> Diff: http://git.reviewboard.kde.org/r/103696/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario Scheel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/