[Kde-pim] Review Request: making kmail network-aware

[Martin Bednar]

> On Jan. 6, 2012, 8:50 p.m., Torgny Nyblom wrote:
> > Any progress?

Tell me what to do with the diffs, I'll do it :) ... waiting for feedback. Sometime in the next couple of days I'll check if it is still applicable to the current tree.
Reading some of my previous comments on this review, I'd like to take this opportunity to apologize to all involved, since even to myself I sound hostile. (Especially to Sergio).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102431/#review9621
-----------------------------------------------------------


On Sept. 27, 2011, 10:03 p.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102431/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2011, 10:03 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Changes Solid calls to not render KMail useless when Solid can't detect network connection (same as Andreas did in isOffline). Asks the user to go online only based on the internal Kmail networkState status, ignoring the status of the network. Modifies behaviour of askToGoOnline() function to return false when there is no network detected, thus making checkMailOnStartup() and checkMail() functions network-aware.
> 
> 
> Diffs
> -----
> 
>   kmail/kmkernel.h 8fddb57 
>   kmail/kmkernel.cpp eb02afa 
>   kmail/kmmainwidget.h 2468f37 
>   kmail/kmmainwidget.cpp 86b278c 
> 
> Diff: http://git.reviewboard.kde.org/r/102431/diff/diff
> 
> 
> Testing
> -------
> 
> compiles,runs, works fine with solid not detecting network, haven't bumped into any issue with Solid working.
> 
> 
> Thanks,
> 
> Martin Bednar
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/