[Kde-pim] Review Request: Add a list of server capabilities

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103627/#review9595
-----------------------------------------------------------

Ship it!


Just a few minor coding style issues. For the deskop version I say "Ship It".


resources/imap/imapresource.cpp
<http://git.reviewboard.kde.org/r/103627/#comment7865>

    put the '{' on the next line



resources/imap/setupserver.cpp
<http://git.reviewboard.kde.org/r/103627/#comment7866>

    Add 'this' as third parameter. It's not really needed, but I think it's easier to read. Moreover, the other connects all have it.



resources/imap/setupserver.cpp
<http://git.reviewboard.kde.org/r/103627/#comment7867>

    Coding style: Placement of '{'



resources/imap/setupserver.cpp
<http://git.reviewboard.kde.org/r/103627/#comment7868>

    Make this a kDebug() at most. Or remove completely now that you have tested it.



resources/imap/setupserver.cpp
<http://git.reviewboard.kde.org/r/103627/#comment7869>

    Coding style: space after '(' / before ')'



resources/imap/setupserver.cpp
<http://git.reviewboard.kde.org/r/103627/#comment7870>

    Coding style: missing spaces


- Ingo Klöcker


On Jan. 5, 2012, 1:37 p.m., Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103627/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2012, 1:37 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Adds a new button to the IMAP settings dialog that opens a dialog that lists the servers capabilities, also adds a helper function to extract that information.
> 
> 
> Diffs
> -----
> 
>   resources/imap/CMakeLists.txt 03b5fd6 
>   resources/imap/imapresource.h 48a7e91 
>   resources/imap/imapresource.cpp 70cf52f 
>   resources/imap/serverinfo.ui PRE-CREATION 
>   resources/imap/setupserver.h 10c186b 
>   resources/imap/setupserver.cpp 68cbedf 
>   resources/imap/setupserverview_desktop.ui 4e0667c 
>   resources/imap/setupserverview_mobile.ui 3ca2258 
> 
> Diff: http://git.reviewboard.kde.org/r/103627/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and seems to work.
> 
> 
> Screenshots
> -----------
> 
> Advanced tab with button
>   http://git.reviewboard.kde.org/r/103627/s/405/
> Server Info dialog
>   http://git.reviewboard.kde.org/r/103627/s/406/
> 
> 
> Thanks,
> 
> Torgny Nyblom
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/