[Kde-pim] Review Request: KAddressBook: improve appearance and operation of IM address editor

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103620/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

The IM address editor within kaddressbook does not look good visually (see attached screenshot 1) and also does not work intuitively when adding a new address (see the referenced bug).  The double-click-to-edit interaction is not used anywhere else within the kaddressbook GUI, and in particular is inconsistent with the email address editor just a few fields away.

This change handles the editing or adding addresses in a new popup dialogue, with a combo box for the protocol and a line edit for the address.  This does involve an additional dialogue box, but actually requires fewer mouse clicks in total to change or add a new address.  The combo box comes out at a suitable size to list all of the protocols without truncation.  See attached screenshots 2 and 3.

Double clicking an item in the address list opens the item editor dialogue, so users who are accustomed to double clicking here will not be surprised.

(Ignore diff r1, earlier version uploaded by mistake)


This addresses bug 244799.
    http://bugs.kde.org/show_bug.cgi?id=244799


Diffs
-----

  akonadi/contact/CMakeLists.txt 505031e 
  akonadi/contact/editor/im/imdelegate.h 9337d9c 
  akonadi/contact/editor/im/imdelegate.cpp 5683022 
  akonadi/contact/editor/im/imeditordialog.h 8bf69ea 
  akonadi/contact/editor/im/imeditordialog.cpp 75ca579 
  akonadi/contact/editor/im/imitemdialog.h PRE-CREATION 
  akonadi/contact/editor/im/imitemdialog.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103620/diff/diff


Testing
-------

Built kdepimlibs with these changes, checked editing, adding and removing IM addresses in kaddressbook.


Screenshots
-----------

Before
  http://git.reviewboard.kde.org/r/103620/s/397/
After 1 - main dialogue
  http://git.reviewboard.kde.org/r/103620/s/398/
After - address editor dialogue
  http://git.reviewboard.kde.org/r/103620/s/399/


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/