[Kde-pim] Review Request: Refactoring handling IMAP responses during login phase in Akonadi

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103854/#review10543
-----------------------------------------------------------


Looks really good. Still a couple of improvements could be done still, but I'm really looking forward to get a final version in. :-)

I successfully tested with PLAIN and NTLM. So we should be well covered now, of course no regresssion on plain text either.
Please address the comments below, resubmit and we should be very close to have this patch getting in.


kimap/loginjob.cpp
<http://git.reviewboard.kde.org/r/103854/#comment8617>

    I agree with the other Kevin comment in part, this logic ought to be factored out. Of course other jobs do their own thing for now, but I clearly see the need to improve that in a consistent way.
    
    So could you please factor out the logic determining the ResponseCode and the ResponseCode type itself inside of the Message class?



kimap/loginjob.cpp
<http://git.reviewboard.kde.org/r/103854/#comment8618>

    This part seems redundent with the if block above to determine the code in the first case. Could have been checked at the time we detected the untagged case.


- Kevin Ottens


On Feb. 5, 2012, 7:02 p.m., Oleg Girko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103854/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2012, 7:02 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Refactoring KIMAP::LoginJob::handleResponse() method in kimap/loginjob.cpp file to make its logic more readable, straightforward and correct.
> As a side effect, it fixes https://bugs.kde.org/show_bug.cgi?id=249992 by handling untagged CAPABILITY responses more correct and uniform way.
> 
> This change is trivially backportable to KDE 4.7 (tested with KDE 4.7.4).
> 
> 
> This addresses bug 249992.
>     http://bugs.kde.org/show_bug.cgi?id=249992
> 
> 
> Diffs
> -----
> 
>   kimap/loginjob.cpp fad276d957e46fd00efa20a5f235d02a639ab2c4 
> 
> Diff: http://git.reviewboard.kde.org/r/103854/diff/
> 
> 
> Testing
> -------
> 
> Successfully tested with Dovecot IMAP server 2.0.17 using CRAM-MD5 and GSSAPI authentication with unencrypted and SSL connection.
> 
> 
> Thanks,
> 
> Oleg Girko
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/